All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: clean up rfcomm code
Date: Tue, 5 Oct 2010 16:42:58 -0300	[thread overview]
Message-ID: <20101005194258.GC3234@vigoh> (raw)
In-Reply-To: <1286265236.17473.26.camel@aeonflux>

Hi Andrei,

* Marcel Holtmann <marcel@holtmann.org> [2010-10-05 09:53:56 +0200]:

> Hi Andrei,
> 
> > Remove dead code and unused rfcomm thread events
> > 
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
> > ---
> >  include/net/bluetooth/rfcomm.h |    5 -----
> >  net/bluetooth/rfcomm/core.c    |   29 ++++++++++++++---------------
> >  2 files changed, 14 insertions(+), 20 deletions(-)
> > 
> > diff --git a/include/net/bluetooth/rfcomm.h b/include/net/bluetooth/rfcomm.h
> > index a140847..71047bc 100644
> > --- a/include/net/bluetooth/rfcomm.h
> > +++ b/include/net/bluetooth/rfcomm.h
> > @@ -213,11 +213,6 @@ struct rfcomm_dlc {
> >  #define RFCOMM_DEFER_SETUP  8
> >  
> >  /* Scheduling flags and events */
> > -#define RFCOMM_SCHED_STATE  0
> > -#define RFCOMM_SCHED_RX     1
> > -#define RFCOMM_SCHED_TX     2
> > -#define RFCOMM_SCHED_TIMEO  3
> > -#define RFCOMM_SCHED_AUTH   4
> >  #define RFCOMM_SCHED_WAKEUP 31
> 
> we had some big ambition to use these, but never did in the end or
> realized that they are not needed. So I am fine with removing these.
> 
> Acked-by: Marcel Holtmann <marcel@holtmann.org>

Patch has been applied. Thanks.


-- 
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi

      reply	other threads:[~2010-10-05 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01  9:05 [PATCH] Bluetooth: clean up rfcomm code Emeltchenko Andrei
2010-10-05  7:53 ` Marcel Holtmann
2010-10-05 19:42   ` Gustavo F. Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101005194258.GC3234@vigoh \
    --to=padovan@profusion.mobi \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.