From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Date: Tue, 5 Oct 2010 15:16:32 -0700 Message-ID: <20101005221631.GT3117@atomide.com> References: <1286015771-22041-1-git-send-email-charu@ti.com> <87fwwktx6r.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:53501 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591Ab0JEWQl (ORCPT ); Tue, 5 Oct 2010 18:16:41 -0400 Content-Disposition: inline In-Reply-To: <87fwwktx6r.fsf@deeprootsystems.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: "Varadarajan, Charulatha" , wim@iguana.be, linux-omap@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, b-cousson@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com, p-basak2@ti.com * Kevin Hilman [101005 09:26]: > "Varadarajan, Charulatha" writes: > > > Inorder to avoid any assumptions from bootloader, the watchdog > > timer module is reset during init. This enables the watchdog > > timer. > > > > Therefore, it is required to disable WDT after it is reset > > during init. Otherwise the system would reboot as per the default > > watchdog timer registers settings. > > > > Later, when the watchdog driver is loaded, the watchdog timer settings > > is adjusted as per the default timer_margin set in the driver and the > > driver would supports the normal operations supported by OMAP watchdog > > timer. > > > > Link to related discussions: > > https://patchwork.kernel.org/patch/219072/ > > > > Issue reported by Kevin can be found at: > > https://patchwork.kernel.org/patch/217262/ > > > > Signed-off-by: Charulatha V > > Reported-by: Kevin Hilman > > Acked-by: Kevin Hilman > > Tony, this should queue up for .37 on top of my pm-hwmods branch. > It applies cleanly to current l-o master. OK, adding to omap-for-linus. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 5 Oct 2010 15:16:32 -0700 Subject: [PATCH v2] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init In-Reply-To: <87fwwktx6r.fsf@deeprootsystems.com> References: <1286015771-22041-1-git-send-email-charu@ti.com> <87fwwktx6r.fsf@deeprootsystems.com> Message-ID: <20101005221631.GT3117@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Kevin Hilman [101005 09:26]: > "Varadarajan, Charulatha" writes: > > > Inorder to avoid any assumptions from bootloader, the watchdog > > timer module is reset during init. This enables the watchdog > > timer. > > > > Therefore, it is required to disable WDT after it is reset > > during init. Otherwise the system would reboot as per the default > > watchdog timer registers settings. > > > > Later, when the watchdog driver is loaded, the watchdog timer settings > > is adjusted as per the default timer_margin set in the driver and the > > driver would supports the normal operations supported by OMAP watchdog > > timer. > > > > Link to related discussions: > > https://patchwork.kernel.org/patch/219072/ > > > > Issue reported by Kevin can be found at: > > https://patchwork.kernel.org/patch/217262/ > > > > Signed-off-by: Charulatha V > > Reported-by: Kevin Hilman > > Acked-by: Kevin Hilman > > Tony, this should queue up for .37 on top of my pm-hwmods branch. > It applies cleanly to current l-o master. OK, adding to omap-for-linus. Tony