From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 04/11] quota: make dquot lists per-sb
Date: Wed, 6 Oct 2010 04:57:44 -0400
Message-ID: <20101006085744.GD7295@lst.de>
References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com>
 <1286302827-31043-5-git-send-email-dmonakhov@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org,
	Dmitry Monakhov <dmonakhov@gmail.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from canuck.infradead.org ([134.117.69.58]:46344 "EHLO
	canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754363Ab0JFI5p (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 6 Oct 2010 04:57:45 -0400
Content-Disposition: inline
In-Reply-To: <1286302827-31043-5-git-send-email-dmonakhov@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Oct 05, 2010 at 10:20:20PM +0400, Dmitry Monakhov wrote:
> Currently quota lists are global which is very bad for scalability.
> * inuse_lists -> sb->s_dquot->dq_inuse_list
> * free_lists  -> sb->s_dquot->dq_free_lists
> * Add per sb lock for quota's lists protection
> 
> Do not remove dq_lists_lock is used now only for protecting quota_hash

I'm not a big fan of adding tons of new fields to the generic superblock
for a handfull filesystems actually using it.  Can you look into
introducing a quota_sb structure that the few filesystems that use
it can embedd into their superblock?