From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Introduce chip
Date: Wed, 06 Oct 2010 16:14:59 +0000 [thread overview]
Message-ID: <20101006161459.GC13958@ericsson.com> (raw)
In-Reply-To: <1286293108-28890-2-git-send-email-guenter.roeck@ericsson.com>
On Wed, Oct 06, 2010 at 12:10:35PM -0400, Jean Delvare wrote:
> On Wed, 6 Oct 2010 08:30:21 -0700, Guenter Roeck wrote:
> > On Wed, Oct 06, 2010 at 11:09:30AM -0400, Jean Delvare wrote:
> > > On Wed, 6 Oct 2010 17:05:53 +0200, Jean Delvare wrote:
> > > > I like this change a lot, even though it makes the binary module a
> > > > little larger.
> > >
> > > Err, scratch that, it doesn't. Not sure why I thought it did...
> > >
> > At least it makes the source a bit larger.
> >
> > One thought: Would it make sense to use initdata for the initialization code ?
>
> Almost impossible for I2C device drivers, as you never know when
> probe() will be called. For example, lm90 could be built into the
> kernel, but the underlying i2c bus driver be loaded as a module...
>
Good point.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-10-06 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 15:38 [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Introduce chip parameter Guenter Roeck
2010-10-06 15:05 ` [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Introduce chip Jean Delvare
2010-10-06 15:09 ` Jean Delvare
2010-10-06 15:28 ` Guenter Roeck
2010-10-06 15:30 ` Guenter Roeck
2010-10-06 16:10 ` Jean Delvare
2010-10-06 16:13 ` Jean Delvare
2010-10-06 16:14 ` Guenter Roeck [this message]
2010-10-06 16:46 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006161459.GC13958@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.