diff for duplicates of <20101006192235.GA13563@erda.amd.com> diff --git a/a/content_digest b/N1/content_digest index f2de322..5731241 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,8 +8,8 @@ "ref\020101006184407.GY13563@erda.amd.com\0" "ref\0AANLkTin579dqJsdtpesJ0erWP3Pgi39XHQs46xMAGJDW@mail.gmail.com\0" "From\0Robert Richter <robert.richter@amd.com>\0" - "Subject\0Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit\0" - "Date\0Wed, 6 Oct 2010 21:22:35 +0200\0" + "Subject\0Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate\0" + "Date\0Wed, 06 Oct 2010 19:22:35 +0000\0" "To\0Grant Likely <grant.likely@secretlab.ca>\0" "Cc\0Paul Mundt <lethal@linux-sh.org>" Matt Fleming <matt@console-pimps.org> @@ -65,4 +65,4 @@ "Advanced Micro Devices, Inc.\n" Operating System Research Center -fffde236f2c19067d806ef14d2d870b50def5df59f72d6d3a72d923728a1450d +d87205f16471b4ae0e6c4119ac5adb0725437e6ed72c4f033033e7c5cf629b08
diff --git a/a/1.txt b/N2/1.txt index 6d13fce..eb0ecf0 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,15 +6,15 @@ On 06.10.10 14:58:06, Grant Likely wrote: > >> >> --- a/drivers/oprofile/oprof.c > >> >> +++ b/drivers/oprofile/oprof.c > >> >> @@ -252,6 +252,8 @@ static int __init oprofile_init(void) -> >> >> { -> >> >> int err; +> >> >> ?{ +> >> >> ? ? ? int err; > >> >> -> >> >> + memset(&oprofile_ops, 0, sizeof(struct oprofile_operations)); +> >> >> + ? ? memset(&oprofile_ops, 0, sizeof(struct oprofile_operations)); > >> >> + > >> > > >> > Yes, this looks much better. Thanks Paul. > >> -> >> oprofile_ops is allocated in bss and so is already zeroed. No need to +> >> oprofile_ops is allocated in bss and so is already zeroed. ?No need to > >> do it explicitly. > > > > Before oprofile_arch_init() it isn't necessarily needed, but we should diff --git a/a/content_digest b/N2/content_digest index f2de322..05bf4be 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -7,23 +7,10 @@ "ref\0AANLkTikGQe99k_fK5pZtkn-ht9jgC0guDkn28dSedjUo@mail.gmail.com\0" "ref\020101006184407.GY13563@erda.amd.com\0" "ref\0AANLkTin579dqJsdtpesJ0erWP3Pgi39XHQs46xMAGJDW@mail.gmail.com\0" - "From\0Robert Richter <robert.richter@amd.com>\0" - "Subject\0Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit\0" + "From\0robert.richter@amd.com (Robert Richter)\0" + "Subject\0[PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit\0" "Date\0Wed, 6 Oct 2010 21:22:35 +0200\0" - "To\0Grant Likely <grant.likely@secretlab.ca>\0" - "Cc\0Paul Mundt <lethal@linux-sh.org>" - Matt Fleming <matt@console-pimps.org> - Will Deacon <will.deacon@arm.com> - Russell King <linux@arm.linux.org.uk> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-sh@vger.kernel.org <linux-sh@vger.kernel.org> - Peter Zijlstra <peterz@infradead.org> - Ingo Molnar <mingo@elte.hu> - Frederic Weisbecker <fweisbec@gmail.com> - Arnaldo Carvalho de Melo <acme@redhat.com> - linux-arch@vger.kernel.org <linux-arch@vger.kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - " Deng-Cheng Zhu <dengcheng.zhu@gmail.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 06.10.10 14:58:06, Grant Likely wrote:\n" @@ -34,15 +21,15 @@ "> >> >> --- a/drivers/oprofile/oprof.c\n" "> >> >> +++ b/drivers/oprofile/oprof.c\n" "> >> >> @@ -252,6 +252,8 @@ static int __init oprofile_init(void)\n" - "> >> >> \302\240{\n" - "> >> >> \302\240 \302\240 \302\240 int err;\n" + "> >> >> ?{\n" + "> >> >> ? ? ? int err;\n" "> >> >>\n" - "> >> >> + \302\240 \302\240 memset(&oprofile_ops, 0, sizeof(struct oprofile_operations));\n" + "> >> >> + ? ? memset(&oprofile_ops, 0, sizeof(struct oprofile_operations));\n" "> >> >> +\n" "> >> >\n" "> >> > Yes, this looks much better. Thanks Paul.\n" "> >>\n" - "> >> oprofile_ops is allocated in bss and so is already zeroed. \302\240No need to\n" + "> >> oprofile_ops is allocated in bss and so is already zeroed. ?No need to\n" "> >> do it explicitly.\n" "> >\n" "> > Before oprofile_arch_init() it isn't necessarily needed, but we should\n" @@ -65,4 +52,4 @@ "Advanced Micro Devices, Inc.\n" Operating System Research Center -fffde236f2c19067d806ef14d2d870b50def5df59f72d6d3a72d923728a1450d +f7e4085dceffb7f947b2039bc56e2231ef896dc1df46cb915c727bdba1849dbe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.