Re: [PATCH] mac80211: avoid uninitialized var warning in ieee80211_scan_cancel

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Wed, Oct 06, 2010 at 04:42:23PM -0400, John W. Linville wrote:
> net/mac80211/scan.c: In function ‘ieee80211_scan_cancel’:
> net/mac80211/scan.c:794: warning: ‘finish’ may be used uninitialized in this function
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Hi John

What compiler are you using? I have no warning with gcc 4.4.4 from RHEL6.
That's correct, as "finish" variable can not be uninitialized, because is used
only when abortscan == true;

> +	bool finish = false;
>  
>  	/*
>  	 * We are only canceling software scan, or deferred scan that was not
> @@ -818,7 +819,7 @@ void ieee80211_scan_cancel(struct ieee80211_local *local)
>  	if (abortscan) {
>  		/* The scan is canceled, but stop work from being pending */
>  		cancel_delayed_work_sync(&local->scan_work);
> -		if (finish)
> -			__ieee80211_scan_completed_finish(&local->hw, false);
>  	}
> +	if (finish)
> +		__ieee80211_scan_completed_finish(&local->hw, false);
>  }

I have nothing against the patch, but this seems to be compiler problem,
not our code.

Stanislaw