All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test
Date: Thu, 7 Oct 2010 08:49:59 +0200	[thread overview]
Message-ID: <201010070850.00126.sr@denx.de> (raw)
In-Reply-To: <20101006210436.91E87153A7E@gemini.denx.de>

Hi Wolfgang,

On Wednesday 06 October 2010 23:04:36 Wolfgang Denk wrote:
> > diff --git a/post/tests.c b/post/tests.c
> > index a4066f9..02bf538 100644
> > --- a/post/tests.c
> > +++ b/post/tests.c
> > @@ -169,7 +169,7 @@ struct post_test post_list[] =
> > 
> >  	"UART test",
> >  	"uart",
> >  	"This test verifies the UART operation.",
> > 
> > -	POST_RAM | POST_SLOWTEST | POST_MANUAL,
> > +	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,
> 
> Instead of globally enforcing this for all boards, can this not be
> done in a board specific way?

Yes, can be done. I could make it board specific as already done for other 
POST tests:

#if CONFIG_POST & CONFIG_SYS_POST_UART
#if defined(CONFIG_POST_UART)
	CONFIG_POST_UART,
#else
    {
	"UART test",
	"uart",
	"This test verifies the UART operation.",
	POST_RAM | POST_SLOWTEST | POST_MANUAL,
	&uart_post_test,
	NULL,
	NULL,
	CONFIG_SYS_POST_UART
    },
#endif

So the board config header could provide a board specific test by defining 
CONFIG_POST_UART. Is this what you would prefer?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2010-10-07  6:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 15:14 [U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test Stefan Roese
2010-10-06 21:04 ` Wolfgang Denk
2010-10-07  6:49   ` Stefan Roese [this message]
2010-10-07 10:11     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010070850.00126.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.