All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, fweisbec@gmail.com, robert.richter@amd.com,
	gorcunov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] arch generic way to trigger unknown NMIs
Date: Thu, 7 Oct 2010 10:01:12 -0400	[thread overview]
Message-ID: <20101007140112.GN10663@redhat.com> (raw)
In-Reply-To: <20101007072641.GE5010@basil.fritz.box>

On Thu, Oct 07, 2010 at 09:26:41AM +0200, Andi Kleen wrote:
> 
> Having a regression test for this is good, but it would 
> be also good if it wasn't a private one but in some public
> git repository.

Yeah, I know.  It isn't meant to be private, mostly glue logic to load
this module using RedHat's internal test harness.

Is there a more public place to add a test like this?  I guess that would
be LTP.  Though last time I looked at LTP, all the tests are written in
'C' whereas I just cobbled together some shell scripts to configure kdump,
load the module, panic, process the resulting vmcore to verify it panic'd
for the right reason.

> 
> >  static struct jprobe lkdtm;
> > @@ -340,6 +343,9 @@ static void lkdtm_do_action(enum ctype which)
> >  		set_current_state(TASK_UNINTERRUPTIBLE);
> >  		schedule();
> >  		break;
> > +	case NMI:
> > +		apic->send_IPI_allbutself(NMI_VECTOR);
> > +		break;
> >  	case NONE:
> >  	default:
> >  		break;
> > 
> > Anyone have any thoughts?  Maybe there is an easier way?
> 
> Do you really want the NMI on all CPUs - 1? Normally it's directed to
> a single one.

No I prefer a single one too, but there didn't seem to be a
send_IPI_self() command, so I took the short route and sent it to
everyone. :-(

Cheers,
Don

> 
> -Andi

  reply	other threads:[~2010-10-07 14:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  3:08 [RFC] arch generic way to trigger unknown NMIs Don Zickus
2010-10-07  7:26 ` Andi Kleen
2010-10-07 14:01   ` Don Zickus [this message]
2010-10-07 15:11     ` Andi Kleen
2010-10-07 15:47       ` Don Zickus
2010-10-07 16:17         ` Andi Kleen
2010-10-07 22:45     ` Maciej W. Rozycki
2010-10-10 20:23       ` Cyrill Gorcunov
2010-10-16  7:24         ` Maciej W. Rozycki
2010-10-16 15:32           ` Cyrill Gorcunov
2010-10-16 16:15             ` Maciej W. Rozycki
2010-10-16 16:36               ` Cyrill Gorcunov
2010-10-16 23:59                 ` Maciej W. Rozycki
2010-10-17  8:58                   ` Cyrill Gorcunov
2010-10-17 16:08                     ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007140112.GN10663@redhat.com \
    --to=dzickus@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.