From: Andres Salomon <dilinger@queued.net>
To: Daniel Drake <dsd@laptop.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OLPC: Add XO-1 poweroff support
Date: Thu, 7 Oct 2010 14:20:03 -0700 [thread overview]
Message-ID: <20101007142003.68b6ad7e@debxo> (raw)
In-Reply-To: <AANLkTind-S=vzba56DmkzR2BixLGUyBTqu4rgaMcSf5w@mail.gmail.com>
On Thu, 7 Oct 2010 21:42:59 +0100
Daniel Drake <dsd@laptop.org> wrote:
> On 7 October 2010 21:09, Andres Salomon <dilinger@queued.net> wrote:
> > Any particular reason why this can't be modular?
>
> Because of the pm_power_off thing.
> Also, a similar situation would be encountered with set_suspend_ops().
>
> I don't really understand your suggestion. If we set it to NULL on
> module unload then the power off would crash on shutdown, right?
>
> Daniel
See arch/x86/kernel/apm_32.c for an example of modular pm_power_off
handling.
Power off shouldn't crash; at least, native_machine_power_off first
check if pm_power_off is !NULL before calling it.
prev parent reply other threads:[~2010-10-07 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 18:59 [PATCH] OLPC: Add XO-1 poweroff support Daniel Drake
2010-10-07 20:09 ` Andres Salomon
2010-10-07 20:42 ` Daniel Drake
2010-10-07 21:20 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007142003.68b6ad7e@debxo \
--to=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.