From: Andres Salomon <dilinger@queued.net>
To: sparclinux@vger.kernel.org
Subject: Re: phandle patch review?
Date: Thu, 07 Oct 2010 23:44:02 +0000 [thread overview]
Message-ID: <20101007164402.02a7a068@debxo> (raw)
In-Reply-To: <AANLkTikaAkPqgKu-+JTbPOjiqKZdOcz+czEGUvvbc00y@mail.gmail.com>
On Thu, 7 Oct 2010 17:01:28 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, Oct 5, 2010 at 1:29 PM, Andres Salomon <dilinger@queued.net>
> wrote:
> > On Tue, 28 Sep 2010 14:59:53 -0700
> > Andres Salomon <dilinger@queued.net> wrote:
> >
> >> On Wed, 29 Sep 2010 05:39:59 +0900
> >> Grant Likely <grant.likely@secretlab.ca> wrote:
> >>
> >> > On Wed, Sep 29, 2010 at 4:48 AM, Andres Salomon
> >> > <dilinger@queued.net> wrote:
> >> > > Hi Grant,
> >> > >
> >> > > I'm assuming the sparc patches can go through your tree as
> >> > > well. Please let me know if anything else needs to happen, now
> >> > > that we have an ACK from davem.
> >> >
> >> > Did the phandle -> types.h issues get sorted out? Â I can't
> >> > remember.
> >>
> >> The relevant thread was here:
> >> https://patchwork.kernel.org/patch/140991/
> >>
> >> I found Sam's initial comment unclear, so I asked for clarification
> >> (specifying that we didn't need phandle to be exported to
> >> userspace); his response was:
> >>
> >> "So the above looks good considerign that userspace
> >> so far does not require ihanlde/phandle."
> >>
> >> I left it open-ended regarding whether or not userspace might want
> >> phandle/ihandle to be exported (that's more a question for you
> >> flat devicetree folks :) , but for my purposes not having it
> >> exposed to userspace is just fine.
> >
> >
> >
> > So yeah, please let me know if there's anything outstanding that I
> > missed that would keep the patches from getting merged.
>
> Okay, I'm confused. As you say, asm/openprom.h is exported. None of
> openprom.h is protect with __KERNEL__, so all of it gets exposed to
> userspace. You're patch adds phandle to the __KERNEL__ protected
> section of types.h, which means that it is unavailable to userspace.
> In which case anything from userspace including asm/openprom.h will
> fail to compile, or am I missing something?
>
Ah, you're right, so phandle will need to be exported to userspace as
well. I will send an updated patch.
prev parent reply other threads:[~2010-10-07 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 23:01 phandle patch review? Grant Likely
2010-10-07 23:44 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007164402.02a7a068@debxo \
--to=dilinger@queued.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.