From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] CHROMIUM: i915: Initialize panel timing
 registers if VBIOS did not.
Date: Thu, 7 Oct 2010 16:52:39 -0700
Message-ID: <20101007165239.1dc815a7@jbarnes-desktop>
References: <AANLkTikoPjDs-RNs+nvOJUO5UWHedGjRT1Ee7kuDyVdO@mail.gmail.com>
	<8u3s8d$jqd8sk@orsmga001.jf.intel.com>
	<AANLkTimrOpY7n9Hi3NRKZVPekg1gNxLLxr1di_cMvf9J@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cpoproxy1-pub.bluehost.com (cpoproxy1-pub.bluehost.com
	[69.89.21.11])
	by gabe.freedesktop.org (Postfix) with SMTP id 96E4B9ECD8
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  7 Oct 2010 16:50:47 -0700 (PDT)
In-Reply-To: <AANLkTimrOpY7n9Hi3NRKZVPekg1gNxLLxr1di_cMvf9J@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Bryan Freed <bfreed@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, Mandeep Baines <msb@chromium.org>, Olof Johansson <olofj@chromium.org>
List-Id: intel-gfx@lists.freedesktop.org

I don't think 0 is a reasonable value for any of those fields, so
checking them against 0 should be fine.

Jesse

On Thu, 7 Oct 2010 16:48:51 -0700
Bryan Freed <bfreed@chromium.org> wrote:

> My change tries to detect the lack of initialization by A) finding no VBT,
> and B) finding 0 values in these registers.
> 
> But what if there is a VBIOS out there that really wants these values to be
> 0?  I provide for that case by checking for VBT.
> 
> Is this a reasonable case?  If not, I have no problem moving the check
> to init_vbt_default().
> 
> bryan.
> 
> On Thu, Oct 7, 2010 at 3:55 PM, Chris Wilson <chris@chris-wilson.co.uk>wrote:
> 
> > On Thu, 7 Oct 2010 15:48:14 -0700, Bryan Freed <bfreed@chromium.org>
> > wrote:
> > > The time between start of the pixel clock and backlight enable is a basic
> > > panel timing constraint.  If no VBIOS Table is found, and the Panel Power
> > > On/Off registers are found to be 0, assume we are booting without VBIOS
> > > initialization and set these registers to something reasonable.
> >
> > IIRC, the panel sequence registers are meant to be stored in the VBIOS. So
> > if we add the parsing of those to the driver and add the defaults to
> > init_vbt_default() then we can check whether PP_ON_DELAYS is valid upon
> > device init (module load and resume) and fixup in case the BIOS does not.
> > -Chris
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
> >


-- 
Jesse Barnes, Intel Open Source Technology Center