Re: [Qemu-devel] [PATCH 07/11] cris: avoid write only variables

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Oct 07, 2010 at 05:57:30PM +0000, Blue Swirl wrote:
> On Thu, Oct 7, 2010 at 11:07 AM, Edgar E. Iglesias
> <edgar.iglesias@gmail.com> wrote:
> > On Thu, Oct 07, 2010 at 12:08:05PM +0200, Markus Armbruster wrote:
> >> Blue Swirl <blauwirbel@gmail.com> writes:
> >>
> >> > Compiling with GCC 4.6.0 20100925 produced warnings:

[...]

> > Markus, I agree that removing tlb_v would have been better than ifdefs,
> > but i think that the intent I originally had in mind was that there should
> > not be a need to flush the entry from the QEMU TLB if the old guest
> > entry was not valid.
> >
> >
> > The following patch works on my side:
> >
> > diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> > index a60da94..be9eb06 100644
> > --- a/target-cris/op_helper.c
> > +++ b/target-cris/op_helper.c
> > @@ -164,7 +164,9 @@ void helper_movl_sreg_reg (uint32_t sreg, uint32_t reg)
> >
> >                        D_LOG("tlb flush vaddr=%x v=%d pc=%x\n",
> >                                  vaddr, tlb_v, env->pc);
> > -                       tlb_flush_page(env, vaddr);
> > +                       if (tlb_v) {
> > +                               tlb_flush_page(env, vaddr);
> > +                       }
> >                }
> >        }
> >  #endif
> >
> >
> > The target-cris/translate_v10.c hunk looks good.
> >
> > Blue, can you incorporate the tlb_v change in your patch set?
> > Or if you prefer, I can commit that part on my side.
> 
> Please do.

OK, done.

Thanks