diff for duplicates of <20101007214137.GA9269@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 7d30c9c..5132bad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ -On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org wrote: -> From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> -> +On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@nvidia.com wrote: +> From: Rhyland Klein <rklein@nvidia.com> +>=20 > adding support for the ISL 29018 ambient light and proximity sensor. -> +>=20 > Addressed comments from reviews by Jonathan Cameron and Joe Perches > * Removed some excess dbg prints that only printed function name > * Renamed some properties to make them more descriptive @@ -11,21 +11,29 @@ On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.g > * Change loops initialization to memset for extensibility. > * used sizeof() instead of ARRAY_SIZE() to be safer > * Added a property to list available adc ranges -> -> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> -> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> +>=20 +> Signed-off-by: Rhyland Klein <rklein@nvidia.com> +> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Too bad no one actually compiled this driver: CC [M] drivers/staging/iio/light/isl29018.o -drivers/staging/iio/light/isl29018.c:420:8: error: ‘show_prox_infrared_suppression’ undeclared here (not in a function) -drivers/staging/iio/light/isl29018.c:433:1: error: ‘iio_dev_attr_range_available’ undeclared here (not in a function) -drivers/staging/iio/light/isl29018.c:435:1: error: ‘iio_dev_attr_adc_resolution_available’ undeclared here (not in a function) -drivers/staging/iio/light/isl29018.c: In function ‘isl29018_chip_init’: -drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable ‘i’ +drivers/staging/iio/light/isl29018.c:420:8: error: =E2=80=98show_prox_i= +nfrared_suppression=E2=80=99 undeclared here (not in a function) +drivers/staging/iio/light/isl29018.c:433:1: error: =E2=80=98iio_dev_att= +r_range_available=E2=80=99 undeclared here (not in a function) +drivers/staging/iio/light/isl29018.c:435:1: error: =E2=80=98iio_dev_att= +r_adc_resolution_available=E2=80=99 undeclared here (not in a function) +drivers/staging/iio/light/isl29018.c: In function =E2=80=98isl29018_chi= +p_init=E2=80=99: +drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable =E2= +=80=98i=E2=80=99 drivers/staging/iio/light/isl29018.c: At top level: -drivers/staging/iio/light/isl29018.c:350:16: warning: ‘show_prox_infrared_supression’ defined but not used -drivers/staging/iio/light/isl29018.c:416:1: warning: ‘iio_const_attr_range_available’ defined but not used -drivers/staging/iio/light/isl29018.c:417:1: warning: ‘iio_const_attr_adc_resolution_available’ defined but not used +drivers/staging/iio/light/isl29018.c:350:16: warning: =E2=80=98show_pro= +x_infrared_supression=E2=80=99 defined but not used +drivers/staging/iio/light/isl29018.c:416:1: warning: =E2=80=98iio_const= +_attr_range_available=E2=80=99 defined but not used +drivers/staging/iio/light/isl29018.c:417:1: warning: =E2=80=98iio_const= +_attr_adc_resolution_available=E2=80=99 defined but not used make[2]: *** [drivers/staging/iio/light/isl29018.o] Error 1 make[1]: *** [drivers/staging/iio/light] Error 2 make: *** [_module_drivers/staging/iio] Error 2 diff --git a/a/content_digest b/N1/content_digest index 57cae4c..5c8b820 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,23 @@ "ref\01286480883-25589-1-git-send-email-rklein@nvidia.com\0" - "ref\01286480883-25589-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>\0" + "From\0Greg KH <greg@kroah.com>\0" "Subject\0Re: [PATCH v5] staging: iio: light: Adding driver for ISL29018 ALS\0" "Date\0Thu, 7 Oct 2010 14:41:37 -0700\0" - "To\0rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "Cc\0jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org" - joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org - achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org - olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org - linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" + "To\0rklein@nvidia.com\0" + "Cc\0jic23@cam.ac.uk" + joe@perches.com + achew@nvidia.com + olof@lixom.net + linux-i2c@vger.kernel.org + linux-kernel@vger.kernel.org + linux-iio@vger.kernel.org + " ldewangan@nvidia.com\0" "\00:1\0" "b\0" - "On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org wrote:\n" - "> From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" - "> \n" + "On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@nvidia.com wrote:\n" + "> From: Rhyland Klein <rklein@nvidia.com>\n" + ">=20\n" "> adding support for the ISL 29018 ambient light and proximity sensor.\n" - "> \n" + ">=20\n" "> Addressed comments from reviews by Jonathan Cameron and Joe Perches\n" "> * Removed some excess dbg prints that only printed function name\n" "> * Renamed some properties to make them more descriptive\n" @@ -27,21 +26,29 @@ "> * Change loops initialization to memset for extensibility.\n" "> * used sizeof() instead of ARRAY_SIZE() to be safer\n" "> * Added a property to list available adc ranges\n" - "> \n" - "> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" - "> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>\n" + ">=20\n" + "> Signed-off-by: Rhyland Klein <rklein@nvidia.com>\n" + "> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>\n" "\n" "Too bad no one actually compiled this driver:\n" " CC [M] drivers/staging/iio/light/isl29018.o\n" - "drivers/staging/iio/light/isl29018.c:420:8: error: \342\200\230show_prox_infrared_suppression\342\200\231 undeclared here (not in a function)\n" - "drivers/staging/iio/light/isl29018.c:433:1: error: \342\200\230iio_dev_attr_range_available\342\200\231 undeclared here (not in a function)\n" - "drivers/staging/iio/light/isl29018.c:435:1: error: \342\200\230iio_dev_attr_adc_resolution_available\342\200\231 undeclared here (not in a function)\n" - "drivers/staging/iio/light/isl29018.c: In function \342\200\230isl29018_chip_init\342\200\231:\n" - "drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable \342\200\230i\342\200\231\n" + "drivers/staging/iio/light/isl29018.c:420:8: error: =E2=80=98show_prox_i=\n" + "nfrared_suppression=E2=80=99 undeclared here (not in a function)\n" + "drivers/staging/iio/light/isl29018.c:433:1: error: =E2=80=98iio_dev_att=\n" + "r_range_available=E2=80=99 undeclared here (not in a function)\n" + "drivers/staging/iio/light/isl29018.c:435:1: error: =E2=80=98iio_dev_att=\n" + "r_adc_resolution_available=E2=80=99 undeclared here (not in a function)\n" + "drivers/staging/iio/light/isl29018.c: In function =E2=80=98isl29018_chi=\n" + "p_init=E2=80=99:\n" + "drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable =E2=\n" + "=80=98i=E2=80=99\n" "drivers/staging/iio/light/isl29018.c: At top level:\n" - "drivers/staging/iio/light/isl29018.c:350:16: warning: \342\200\230show_prox_infrared_supression\342\200\231 defined but not used\n" - "drivers/staging/iio/light/isl29018.c:416:1: warning: \342\200\230iio_const_attr_range_available\342\200\231 defined but not used\n" - "drivers/staging/iio/light/isl29018.c:417:1: warning: \342\200\230iio_const_attr_adc_resolution_available\342\200\231 defined but not used\n" + "drivers/staging/iio/light/isl29018.c:350:16: warning: =E2=80=98show_pro=\n" + "x_infrared_supression=E2=80=99 defined but not used\n" + "drivers/staging/iio/light/isl29018.c:416:1: warning: =E2=80=98iio_const=\n" + "_attr_range_available=E2=80=99 defined but not used\n" + "drivers/staging/iio/light/isl29018.c:417:1: warning: =E2=80=98iio_const=\n" + "_attr_adc_resolution_available=E2=80=99 defined but not used\n" "make[2]: *** [drivers/staging/iio/light/isl29018.o] Error 1\n" "make[1]: *** [drivers/staging/iio/light] Error 2\n" "make: *** [_module_drivers/staging/iio] Error 2\n" @@ -52,4 +59,4 @@ "\n" greg k-h -012e9714e5adbfed51121d4fda6a2ac927a7423219cf4128944779fd3f3ddaaf +739e86e932698300ed4bbccd076b31f4891b0c347b9c2e3fd622c7eee5454d45
diff --git a/a/1.txt b/N2/1.txt index 7d30c9c..83df67e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,5 +1,5 @@ -On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org wrote: -> From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@nvidia.com wrote: +> From: Rhyland Klein <rklein@nvidia.com> > > adding support for the ISL 29018 ambient light and proximity sensor. > @@ -12,8 +12,8 @@ On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.g > * used sizeof() instead of ARRAY_SIZE() to be safer > * Added a property to list available adc ranges > -> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> -> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> +> Signed-off-by: Rhyland Klein <rklein@nvidia.com> +> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Too bad no one actually compiled this driver: CC [M] drivers/staging/iio/light/isl29018.o diff --git a/a/content_digest b/N2/content_digest index 57cae4c..2e3adcf 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,21 +1,20 @@ "ref\01286480883-25589-1-git-send-email-rklein@nvidia.com\0" - "ref\01286480883-25589-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>\0" + "From\0Greg KH <greg@kroah.com>\0" "Subject\0Re: [PATCH v5] staging: iio: light: Adding driver for ISL29018 ALS\0" "Date\0Thu, 7 Oct 2010 14:41:37 -0700\0" - "To\0rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "Cc\0jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org" - joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org - achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org - olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org - linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" + "To\0rklein@nvidia.com\0" + "Cc\0jic23@cam.ac.uk" + joe@perches.com + achew@nvidia.com + olof@lixom.net + linux-i2c@vger.kernel.org + linux-kernel@vger.kernel.org + linux-iio@vger.kernel.org + " ldewangan@nvidia.com\0" "\00:1\0" "b\0" - "On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org wrote:\n" - "> From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + "On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@nvidia.com wrote:\n" + "> From: Rhyland Klein <rklein@nvidia.com>\n" "> \n" "> adding support for the ISL 29018 ambient light and proximity sensor.\n" "> \n" @@ -28,8 +27,8 @@ "> * used sizeof() instead of ARRAY_SIZE() to be safer\n" "> * Added a property to list available adc ranges\n" "> \n" - "> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" - "> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>\n" + "> Signed-off-by: Rhyland Klein <rklein@nvidia.com>\n" + "> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>\n" "\n" "Too bad no one actually compiled this driver:\n" " CC [M] drivers/staging/iio/light/isl29018.o\n" @@ -52,4 +51,4 @@ "\n" greg k-h -012e9714e5adbfed51121d4fda6a2ac927a7423219cf4128944779fd3f3ddaaf +5e4569636bbe3252d3700cda90a9eaca62cbbb71d7f7073cf8e6196dd99ae5c2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.