From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: on multiuser mount, set ownership to current_fsuid/current_fsgid (try #5)
Date: Fri, 8 Oct 2010 07:11:37 -0400 [thread overview]
Message-ID: <20101008071137.45a4e27c@corrin.poochiereds.net> (raw)
In-Reply-To: <AANLkTimTO_aBJFm==qLkRhXG-LVbMH7CqCdFhkxHAhCB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 7 Oct 2010 22:25:23 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> One case does seem strange - I forgot what happens when you specify a
> mnt_uid of 0 (root)
>
Oof, you're right... we should base this on CIFS_MOUNT_OVERR_UID and
CIFS_MOUNT_OVERR_GID flags instead. I'll send a fixed patch once I've
tested it.
Now that I think about this though, maybe we shouldn't do this based on
CIFS_MOUNT_MULTIUSER but instead on CIFS_MOUNT_NO_PERM? It would mean
a behavior change for anyone currently "-o noperm" on a mount without
unix extensions but I think it would make a bit more sense than special
casing CIFS_MOUNT_MULTIUSER here.
Thoughts?
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2010-10-08 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 18:46 [PATCH] cifs: on multiuser mount, set ownership to current_fsuid/current_fsgid (try #5) Jeff Layton
[not found] ` <1286477188-26681-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-07 18:48 ` Steve French
[not found] ` <AANLkTimTO_aBJFm==qLkRhXG-LVbMH7CqCdFhkxHAhCB@mail.gmail.com>
[not found] ` <AANLkTimTO_aBJFm==qLkRhXG-LVbMH7CqCdFhkxHAhCB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-08 11:11 ` Jeff Layton [this message]
[not found] ` <20101008071137.45a4e27c-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-10-08 15:33 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008071137.45a4e27c@corrin.poochiereds.net \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.