From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754209Ab0JHHYM (ORCPT ); Fri, 8 Oct 2010 03:24:12 -0400 Received: from canuck.infradead.org ([134.117.69.58]:55177 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753992Ab0JHHYL (ORCPT ); Fri, 8 Oct 2010 03:24:11 -0400 Date: Fri, 8 Oct 2010 03:24:10 -0400 From: Christoph Hellwig To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/18] fs: add inode reference coutn read accessor Message-ID: <20101008072410.GA7831@lst.de> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-9-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1286515292-15882-9-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 08, 2010 at 04:21:22PM +1100, Dave Chinner wrote: > From: Dave Chinner > > To remove most of the remaining direct references to the inode > reference count, add an iref_read() accessor function to read the > current reference count. New users of this function should be > frowned upon, as there is rarely a good reason for looking at the > current reference count. IMHO adding this is rather pointless, it's not really buying us anything. But at least it looks correct.