From: matt mooney <mfm@muteddisk.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>
Subject: Re: [RFC PATCH] usb: makefile cleanup
Date: Fri, 8 Oct 2010 00:47:07 -0700 [thread overview]
Message-ID: <20101008074707.GA32564@haskell.muteddisk.com> (raw)
In-Reply-To: <20101006165004.GA25221@merkur.ravnborg.org>
On 18:50 Wed 06 Oct , Sam Ravnborg wrote:
> On Wed, Oct 06, 2010 at 12:51:41AM -0700, matt mooney wrote:
> > For all modules, change <module>-objs to <module>-y; remove
> > if-statements and replace with lists using the kbuild idiom; move
> > flags to the top of the file; and fix alignment while trying to
> > maintain the original scheme in each file.
> >
> > None of the dependencies are modified.
> >
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
>
> Looks good. I agree with Michal's comment about
> moving the complexity from MAkefile to Kconfig.
> But I think that should be a follow-up patch.
>
> You can add my:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Two trivial comments...
> You can keep my ack independent of addressing these comments or not.
>
> Sam
>
> > diff --git a/drivers/usb/host/whci/Kbuild b/drivers/usb/host/whci/Kbuild
> > index 11e5040..26df013 100644
> > --- a/drivers/usb/host/whci/Kbuild
> > +++ b/drivers/usb/host/whci/Kbuild
> > @@ -3,7 +3,7 @@ obj-$(CONFIG_USB_WHCI_HCD) += whci-hcd.o
> > whci-hcd-y := \
> > asl.o \
> > debug.o \
> > - hcd.o \
> > + hcd.o \
> > hw.o \
> > init.o \
> > int.o \
>
> I would be good to loose the "\"
>
> > diff --git a/drivers/usb/wusbcore/Makefile b/drivers/usb/wusbcore/Makefile
> > index f0d8045..b3bd313 100644
> > --- a/drivers/usb/wusbcore/Makefile
> > +++ b/drivers/usb/wusbcore/Makefile
> > @@ -1,9 +1,11 @@
> > +ccflags-$(CONFIG_USB_WUSB_CBAF_DEBUG) := -DDEBUG
> > +
> > obj-$(CONFIG_USB_WUSB) += wusbcore.o
> > obj-$(CONFIG_USB_HWA_HCD) += wusb-wa.o
> > obj-$(CONFIG_USB_WUSB_CBAF) += wusb-cbaf.o
> >
> >
> > -wusbcore-objs := \
> > +wusbcore-y := \
> > crypto.o \
> > devconnect.o \
> > dev-sysfs.o \
> > @@ -14,11 +16,10 @@ wusbcore-objs := \
> > security.o \
> > wusbhc.o
> >
> > -wusb-cbaf-objs := cbaf.o
> > +wusb-cbaf-y := cbaf.o
> >
> > -wusb-wa-objs := wa-hc.o \
> > - wa-nep.o \
> > - wa-rpipe.o \
> > - wa-xfer.o
> > -
> > -ccflags-$(CONFIG_USB_WUSB_CBAF_DEBUG) := -DDEBUG
> > +wusb-wa-y := \
> > + wa-hc.o \
> > + wa-nep.o \
> > + wa-rpipe.o \
> > + wa-xfer.o
> This file could also benefit from loosing the excessive use of "\".
Maybe this should have been changed. A lot of the staging makefiles are doing
this.
-mfm
k
prev parent reply other threads:[~2010-10-08 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 7:51 [RFC PATCH] usb: makefile cleanup matt mooney
2010-10-06 12:01 ` Michal Marek
2010-10-07 0:17 ` matt mooney
2010-10-06 16:50 ` Sam Ravnborg
2010-10-07 0:31 ` matt mooney
2010-10-08 7:47 ` matt mooney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008074707.GA32564@haskell.muteddisk.com \
--to=mfm@muteddisk.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.