Re: linux-next: build warnings after merge of the kbuild-current tree

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Fri, Oct 08, 2010 at 04:51:41PM +0200, Michal Marek wrote:
>
>From ca22d6b4c7c26a8ff9092036a9524bc5ba817277 Mon Sep 17 00:00:00 2001
>From: Michal Marek <mmarek@suse.cz>
>Date: Fri, 8 Oct 2010 16:40:27 +0200
>Subject: [PATCH] kconfig: Temporarily disable dependency warnings
>
>After fixing a use-after-free bug in kconfig, a 'make defconfig' or
>'make allmodconfig' fills the screen with warnings that were not
>detected before. Given that we are close to the release now, disable the
>warnings temporarily and deal with them after 2.6.36.
>
>Signed-off-by: Michal Marek <mmarek@suse.cz>
>
>diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
>index 943712c..d3cfa49 100644
>--- a/scripts/kconfig/symbol.c
>+++ b/scripts/kconfig/symbol.c
>@@ -350,7 +350,7 @@ void sym_calc_value(struct symbol *sym)
> 				}
> 			}
> 		calc_newval:
>-			if (sym->dir_dep.tri == no && sym->rev_dep.tri != no) {
>+			if (0 && sym->dir_dep.tri == no && sym->rev_dep.tri != no) {
> 				fprintf(stderr, "warning: (");
> 				expr_fprint(sym->rev_dep.expr, stderr);
> 				fprintf(stderr, ") selects %s which has unmet direct dependencies (",

Well, this is an odd way to comment a block of code out,
usually we use #ifdef 0 instead. :)


-- 
Live like a child, think like the god.