From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:41641 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758499Ab0JHPJ5 (ORCPT ); Fri, 8 Oct 2010 11:09:57 -0400 Date: Fri, 8 Oct 2010 11:09:54 -0400 From: Matthew Wilcox Subject: Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions Message-ID: <20101008150954.GA18531@linux.intel.com> References: <1286476470-15265-1-git-send-email-tlinder@codeaurora.org> <20101007210919.GA26660@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Brokhman Tatyana Cc: Greg KH , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Sarah Sharp , linux-kernel@vger.kernel.org On Fri, Oct 08, 2010 at 05:35:40AM -0700, Brokhman Tatyana wrote: > >> + */ > >> +#define USB_DEVICE_U1_ENABLE 48 /* dev may initiate U1 transition */ > >> +#define USB_DEVICE_U2_ENABLE 49 /* dev may initiate U2 transition*/ > >> +#define USB_DEVICE_LTM_ENABLE 50 /* dev may send LTM*/ > >> +#define USB_INTRF_FUNC_SUSPEND 0 /* function suspend*/ Missing space before the '*/' on these three lines. > > __le16? I'm guessing these fields haven't actually been used for > > anything? > > Actually __bU2DevExitLat is not bitwise field so it can remain __u16. And > no, their values have been used for nothing but testing the descriptor. The __le16 isn't about bitfields. It's about the fact that the bytes are stored in little-endian form.