From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: Configuration of nestedhvm Date: Fri, 8 Oct 2010 15:48:56 +0200 Message-ID: <201010081548.57601.Christoph.Egger@amd.com> References: <987664A83D2D224EAE907B061CE93D530163EA9749@orsmsx505.amr.corp.intel.com> <201010081202.27671.Christoph.Egger@amd.com> <1A42CE6F5F474C41B63392A5F80372B22DC7D908@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B22DC7D908@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: Keir, "xen-devel@lists.xensource.com" , Fraser List-Id: xen-devel@lists.xenproject.org On Friday 08 October 2010 15:33:53 Dong, Eddie wrote: > Christoph Egger wrote: > > On Friday 08 October 2010 10:54:58 Dong, Eddie wrote: > >> Christoph Egger wrote: > >>> Eddie, > >>> > >>> you can simplify the second patch with attached patch merged > >>> and is correct for AMD side. > >> > >> cpu_has_vmx is not enough. We need to check the configuration > >> (global and per domain), not HW feature availability. > > > > Can you *merge* that patch into yours, please? > > What do you mean? Do you want me to re-post your tools patch w/ this one > merged? > > If you are talking about the attached part of the patch, my patch 2 is > exactly the replacement. Oh, sorry. I thought, it was to allow the guest to set the VMX bit in CR4 - analogous to my 'efer' patch which allows the guest to set the SVME bit in EFER. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632