From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Fri, 8 Oct 2010 16:25:39 -0700 Subject: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM In-Reply-To: <20101008230451.GB10975@n2100.arm.linux.org.uk> References: <1286444662-16843-1-git-send-email-felipe.contreras@gmail.com> <20101007192245.GC26435@n2100.arm.linux.org.uk> <20101008175308.GA10975@n2100.arm.linux.org.uk> <20101008230451.GB10975@n2100.arm.linux.org.uk> Message-ID: <20101008232539.GA28697@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Oct 09, 2010 at 12:04:51AM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 08, 2010 at 10:37:10PM +0300, Felipe Contreras wrote: > > People have been discussing them, but you can't expect a perfect > > solution to pop up within one release cycle, specially when people > > have real issues to deal with. > > Two release cycles. It was queued for the previous release, was posted > to the mailing list, was de-queued, and then re-added for the last merge > window. > > That's not no warning - that's almost six months. > > http://lists.arm.linux.org.uk/lurker/message/20100408.094818.d6854bd5.en.html > > So what you're telling me is that in six months, not one driver has been > touched to address this issue? So, if no one in that time has done any > work on this, then what use is it going to be making the kernel issue > a warning instead? > > So, since this has been known about for six months to the day, I completely > fail to see how making this a warning instead will create the necessary > motivation for the issue to be addressed. I doubt that people even noticed that this was a problem. Unless you throw a run-time warning at them, or even better, break the build of their drivers, they will not notice. Also, how can we fix this in a driver, what is the proper steps to do so? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759207Ab0JHXZ4 (ORCPT ); Fri, 8 Oct 2010 19:25:56 -0400 Received: from kroah.org ([198.145.64.141]:34044 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863Ab0JHXZz (ORCPT ); Fri, 8 Oct 2010 19:25:55 -0400 Date: Fri, 8 Oct 2010 16:25:39 -0700 From: Greg KH To: Russell King - ARM Linux Cc: Felipe Contreras , linux-main , linux-arm , Arnd Hannemann , Han Jonghun , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Hemant Pedanekar Subject: Re: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM Message-ID: <20101008232539.GA28697@kroah.com> References: <1286444662-16843-1-git-send-email-felipe.contreras@gmail.com> <20101007192245.GC26435@n2100.arm.linux.org.uk> <20101008175308.GA10975@n2100.arm.linux.org.uk> <20101008230451.GB10975@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101008230451.GB10975@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 09, 2010 at 12:04:51AM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 08, 2010 at 10:37:10PM +0300, Felipe Contreras wrote: > > People have been discussing them, but you can't expect a perfect > > solution to pop up within one release cycle, specially when people > > have real issues to deal with. > > Two release cycles. It was queued for the previous release, was posted > to the mailing list, was de-queued, and then re-added for the last merge > window. > > That's not no warning - that's almost six months. > > http://lists.arm.linux.org.uk/lurker/message/20100408.094818.d6854bd5.en.html > > So what you're telling me is that in six months, not one driver has been > touched to address this issue? So, if no one in that time has done any > work on this, then what use is it going to be making the kernel issue > a warning instead? > > So, since this has been known about for six months to the day, I completely > fail to see how making this a warning instead will create the necessary > motivation for the issue to be addressed. I doubt that people even noticed that this was a problem. Unless you throw a run-time warning at them, or even better, break the build of their drivers, they will not notice. Also, how can we fix this in a driver, what is the proper steps to do so? thanks, greg k-h