All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: linuxrocks123@netscape.net, netdev@vger.kernel.org
Subject: Re: [PATCH] Add IRQF_SAMPLE_RANDOM Flag to forcedeth
Date: Sat, 09 Oct 2010 20:15:01 -0700 (PDT)	[thread overview]
Message-ID: <20101009.201501.214209347.davem@davemloft.net> (raw)
In-Reply-To: <20101010010924.GB15074@solarflare.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sun, 10 Oct 2010 02:09:24 +0100

> Patrick Simmons wrote:
>> This patch adds the IRQF_SAMPLE_RANDOM flag to the forcedeth driver, 
>> allowing the interrupt timing for forcedeth to be used for entropy 
>> generation.  This should help /dev/random generate more secure random 
>> numbers on machines using this driver.
> [...]
> 
> We don't enable this for network drivers any more because:
> 
> 1. At high packet rates, interrupt moderation makes interrupts very
> regular.
> 2. At low packet rates, a malicious sender can control the interrupt
> timing.

Agreed on all counts, I'm not applying this patch.

  reply	other threads:[~2010-10-10  3:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-09 23:45 [PATCH] Add IRQF_SAMPLE_RANDOM Flag to forcedeth Patrick Simmons
2010-10-10  1:09 ` Ben Hutchings
2010-10-10  3:15   ` David Miller [this message]
2010-10-10  3:23     ` Patrick Simmons
2010-10-10  8:57       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101009.201501.214209347.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=linuxrocks123@netscape.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.