From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, leitao@linux.vnet.ibm.com,
netdev@vger.kernel.org, fubar@us.ibm.com
Subject: Re: [PATCH] ehea: Fix a checksum issue on the receive path
Date: Sat, 9 Oct 2010 10:31:36 -0700 [thread overview]
Message-ID: <20101009103136.341104c5@nehalam> (raw)
In-Reply-To: <20101009.092043.58419374.davem@davemloft.net>
On Sat, 09 Oct 2010 09:20:43 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 08 Oct 2010 16:36:17 +0200
>
> > I am pretty sure most (if not all) netdev drivers pass the packet with
> > invalid checksum to upper stack, so that we can increment appropriate
> > SNMP counters, in IP stack or UDP/TCP/whatever stack.
> >
> > tg3, bnx2, e1000, skge, sky2, bnx2x, niu, r8169, igb, ... seems to do
> > that.
>
> Drivers _must_ send up all packets, even those with bad checksums,
> without exception.
>
> Otherwise protocol statistics get lost, netfilter log entries go
> missing, etc.
Also hardware checksum can be wrong/broken. By passing up a packet
which the driver thinks is bad, the software can still work.
next prev parent reply other threads:[~2010-10-09 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 23:17 [PATCH] ehea: Fix a checksum issue on the receive path leitao
2010-10-08 4:45 ` Eric Dumazet
2010-10-08 14:14 ` Breno Leitao
2010-10-08 14:36 ` Eric Dumazet
2010-10-09 16:20 ` David Miller
2010-10-09 17:31 ` Stephen Hemminger [this message]
2010-10-13 14:06 ` Breno Leitao
2010-10-13 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009103136.341104c5@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.