All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Roman Tereshonkov <roman.tereshonkov@nokia.com>,
	linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH] kobject: name reference should not be lost when lack of memory error happens
Date: Sat, 9 Oct 2010 11:32:31 -0700	[thread overview]
Message-ID: <20101009183231.GA10094@kroah.com> (raw)
In-Reply-To: <AANLkTikmWqc6-jYWr5G7OdboA+TSgCM4qKVfJBNMjPZ=@mail.gmail.com>

On Sat, Oct 09, 2010 at 04:32:44PM +0200, Kay Sievers wrote:
> On Thu, Oct 7, 2010 at 19:53, Greg KH <greg@kroah.com> wrote:
> > On Thu, Oct 07, 2010 at 01:32:53PM +0300, Roman Tereshonkov wrote:
> >> If lack of memory error happens we must restore the old kobject name reference
> >
> > No, we can't do that, as the caller will not be expecting that to have
> > happened, right Kay?
> >
> > I think the code as-is is correct, your kobject is in an unknown state
> > and can't be used anymore.
> 
> Yeah, we've been there several times already with no clear decision so far.
> 
> Trying to set a kobject name twice seems like a serious bug.
> 
> We should kill the old_name logic, and add a WARN() when kobj->name is
> already set when the function is called, I think.

Agreed, it will be interesting to see what is trying to do this :)

thanks,

greg k-h

      reply	other threads:[~2010-10-09 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07 10:32 [PATCH] kobject: name reference should not be lost when lack of memory error happens Roman Tereshonkov
2010-10-07 17:53 ` Greg KH
2010-10-09 14:32   ` Kay Sievers
2010-10-09 18:32     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101009183231.GA10094@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roman.tereshonkov@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.