[Bug 16140] Suspend To RAM/ Resume broken - Radeon KMS on RV250

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=16140





--- Comment #32 from Sedat Dilek <sedat.dilek@gmail.com>  2010-10-10 13:40:58 ---
(Patch see https://bugzilla.kernel.org/show_bug.cgi?id=16140#c26)

With applying my patch from above, it's this section (Line #1028 and following)
from r100_cp_init() doing the problem:

 940 int r100_cp_init(struct radeon_device *rdev, unsigned ring_size)
...
1026         radeon_ring_start(rdev);
1027         r = radeon_ring_test(rdev);
1028         if (r) {
1029                 DRM_ERROR("radeon: cp isn't working (%d).\n", r);
1030                 return r;
1031         }
1032         rdev->cp.ready = true;
1033         return 0;
1034 }
...

Replacing "if (r) {" with "if (WARN_ON(r)) {" shows the above Call-trace.
I looked into r600.c source-code and put "rdev->cp.ready = true;" before Line
"r = radeon_ring_test(rdev);", not helping.

Again inspired from r600.c, I put Line #966 "r100_cp_load_microcode(rdev);"
after "r = radeon_ring_init(rdev, ring_size);", this resulted in a
not-so-garbled screen, after hanging:
pm-resume in X -> switching to vt-1 -> killing X -> restarting startx

This is doing no harm, see my logs.
-        DRM_ERROR("radeon: ring test failed (sracth(0x%04X)=0x%08X)\n",
+        DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",

I am not sure what you mean with "radeon driver": the one in the kernel or the
DDX (xf86-video-ati).

One NOTE:
In Line #3728 there is a commented "r100_gpu_init(rdev);", it is nowhere
"defined". I see in r600.c a *_gpu_init() and a *_cp_start() in case of
resuming. Just a hint, if you wanna compare or dig into it.

IIRC it would make sense to interprete correctly the Call-trace, I am not that
familiar with "the internals".

Sorry, I don't wanna experiment with older Linux-Kernels as my graphics driver
stack is mostly latest-stable or from GIT, not sure what will happen.

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/gpu/drm/radeon/r100.c;h=e151f16a8f86d73090ec6a4eb17a3590661868db;hb=HEAD#l1028
[2]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/gpu/drm/radeon/r100.c;h=e151f16a8f86d73090ec6a4eb17a3590661868db;hb=HEAD#l966
[3]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/gpu/drm/radeon/r100.c;h=e151f16a8f86d73090ec6a4eb17a3590661868db;hb=HEAD#l3728

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
--