Re: [PATCH 2/3] Add Opticon OPN2001 write support

[Greg KH <greg@kroah.com>]

On Sun, Oct 10, 2010 at 05:58:39PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/10/10 16:34, Greg KH wrote:
>
>>>> OPN2001 expects write operations to arrive as a vendor-specific command
>>>> through the control pipe (instead of using a separate bulk-out pipe).
>
>>>> Signed-off-by: Alon Ziv<alon-git@nolaviz.org>
>>>> ---
>>>>    drivers/usb/serial/opticon.c |   30 ++++++++++++++++++++++++++----
>>>>    1 files changed, 26 insertions(+), 4 deletions(-)
>
>>>> diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
>>>> index 9ff19c8..4fe7c3d 100644
>>>> --- a/drivers/usb/serial/opticon.c
>>>> +++ b/drivers/usb/serial/opticon.c
>>> [...]
>
>>>> +	} else {
>>>> +		struct usb_ctrlrequest *dr;
>>>> +
>>>> +		dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_NOIO);
>
>>>     sizeof(*dr) is a preferred form.
>
>> No, people disagree on this, there is no 'preferred' form, you are free
>> to use either way.
>
>    Please refer to the CodingStyle chapter 14. This is preferred form, 
> according to it...

Hm, I didn't realize it had been written down.

Anyway, again, no big deal, it's up to the author/maintainer which way
they prefer, and for me, I can handle it either way.

thanks,

greg k-h