From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Date: Mon, 11 Oct 2010 13:00:15 +0100 Message-ID: <20101011120014.GJ9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 61388103937 for ; Mon, 11 Oct 2010 14:00:16 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1286731745-18169-1-git-send-email-segooon@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Sun, Oct 10, 2010 at 09:29:04PM +0400, Vasiliy Kulikov wrote: > kzalloc() returns NULL on error, not ERR_PTR(). > Also wm8804_modinit() didn't called i2c_del_driver() if > spi_register_driver() failed. > > Signed-off-by: Vasiliy Kulikov Please try to follow Documentation/SubmittingPatches - in particular, you should always split unrelated changes into separate patches. In this case your I2C and kzalloc() changes have nothing to do with each other and so should be in separate patches, and the kzalloc() changes were already applied from a patch by someone else. For the registration changes... > @@ -804,6 +804,7 @@ static int __init wm8804_modinit(void) > if (ret) { > printk(KERN_ERR "Failed to register wm8804 I2C driver: %d\n", > ret); > + goto err; > } > #endif > #if defined(CONFIG_SPI_MASTER) ...it's not clear to me that this change is an improvement - it'll make the driver more fragile in the face of errors, I don't see a benefit in refusing to register the variant for one bus if the other fails? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 11 Oct 2010 12:00:15 +0000 Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-Id: <20101011120014.GJ9231@rakim.wolfsonmicro.main> List-Id: References: <1286731745-18169-1-git-send-email-segooon@gmail.com> In-Reply-To: <1286731745-18169-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood On Sun, Oct 10, 2010 at 09:29:04PM +0400, Vasiliy Kulikov wrote: > kzalloc() returns NULL on error, not ERR_PTR(). > Also wm8804_modinit() didn't called i2c_del_driver() if > spi_register_driver() failed. > > Signed-off-by: Vasiliy Kulikov Please try to follow Documentation/SubmittingPatches - in particular, you should always split unrelated changes into separate patches. In this case your I2C and kzalloc() changes have nothing to do with each other and so should be in separate patches, and the kzalloc() changes were already applied from a patch by someone else. For the registration changes... > @@ -804,6 +804,7 @@ static int __init wm8804_modinit(void) > if (ret) { > printk(KERN_ERR "Failed to register wm8804 I2C driver: %d\n", > ret); > + goto err; > } > #endif > #if defined(CONFIG_SPI_MASTER) ...it's not clear to me that this change is an improvement - it'll make the driver more fragile in the face of errors, I don't see a benefit in refusing to register the variant for one bus if the other fails? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111Ab0JKMAT (ORCPT ); Mon, 11 Oct 2010 08:00:19 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47529 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753063Ab0JKMAR (ORCPT ); Mon, 11 Oct 2010 08:00:17 -0400 Date: Mon, 11 Oct 2010 13:00:15 +0100 From: Mark Brown To: Vasiliy Kulikov Cc: kernel-janitors@vger.kernel.org, Ian Lartey , Dimitris Papastamos , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-ID: <20101011120014.GJ9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1286731745-18169-1-git-send-email-segooon@gmail.com> X-Cookie: Help a swallow land at Capistrano. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 10, 2010 at 09:29:04PM +0400, Vasiliy Kulikov wrote: > kzalloc() returns NULL on error, not ERR_PTR(). > Also wm8804_modinit() didn't called i2c_del_driver() if > spi_register_driver() failed. > > Signed-off-by: Vasiliy Kulikov Please try to follow Documentation/SubmittingPatches - in particular, you should always split unrelated changes into separate patches. In this case your I2C and kzalloc() changes have nothing to do with each other and so should be in separate patches, and the kzalloc() changes were already applied from a patch by someone else. For the registration changes... > @@ -804,6 +804,7 @@ static int __init wm8804_modinit(void) > if (ret) { > printk(KERN_ERR "Failed to register wm8804 I2C driver: %d\n", > ret); > + goto err; > } > #endif > #if defined(CONFIG_SPI_MASTER) ...it's not clear to me that this change is an improvement - it'll make the driver more fragile in the face of errors, I don't see a benefit in refusing to register the variant for one bus if the other fails?