From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Date: Mon, 11 Oct 2010 13:36:09 +0100 Message-ID: <20101011123609.GL9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 9D39D103934 for ; Mon, 11 Oct 2010 14:36:11 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20101011121555.GA32652@albatros> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, Oct 11, 2010 at 04:15:55PM +0400, Vasiliy Kulikov wrote: > On Mon, Oct 11, 2010 at 13:00 +0100, Mark Brown wrote: > > ...it's not clear to me that this change is an improvement - it'll make > > the driver more fragile in the face of errors, I don't see a benefit in > > refusing to register the variant for one bus if the other fails? > I tried to implement your variant with depca driver in past, but it was > rejected by David Miller: > http://lists.openwall.net/netdev/2010/07/12/9 I disagree with David here, and in any case if you're going to make a style change like this they really ought to be applied over all drivers rather than just a few individual ones. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 11 Oct 2010 12:36:09 +0000 Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-Id: <20101011123609.GL9231@rakim.wolfsonmicro.main> List-Id: References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> In-Reply-To: <20101011121555.GA32652@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood On Mon, Oct 11, 2010 at 04:15:55PM +0400, Vasiliy Kulikov wrote: > On Mon, Oct 11, 2010 at 13:00 +0100, Mark Brown wrote: > > ...it's not clear to me that this change is an improvement - it'll make > > the driver more fragile in the face of errors, I don't see a benefit in > > refusing to register the variant for one bus if the other fails? > I tried to implement your variant with depca driver in past, but it was > rejected by David Miller: > http://lists.openwall.net/netdev/2010/07/12/9 I disagree with David here, and in any case if you're going to make a style change like this they really ought to be applied over all drivers rather than just a few individual ones. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393Ab0JKMgN (ORCPT ); Mon, 11 Oct 2010 08:36:13 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:33730 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754275Ab0JKMgM (ORCPT ); Mon, 11 Oct 2010 08:36:12 -0400 Date: Mon, 11 Oct 2010 13:36:09 +0100 From: Mark Brown To: Vasiliy Kulikov Cc: kernel-janitors@vger.kernel.org, Ian Lartey , Dimitris Papastamos , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-ID: <20101011123609.GL9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101011121555.GA32652@albatros> X-Cookie: Help a swallow land at Capistrano. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2010 at 04:15:55PM +0400, Vasiliy Kulikov wrote: > On Mon, Oct 11, 2010 at 13:00 +0100, Mark Brown wrote: > > ...it's not clear to me that this change is an improvement - it'll make > > the driver more fragile in the face of errors, I don't see a benefit in > > refusing to register the variant for one bus if the other fails? > I tried to implement your variant with depca driver in past, but it was > rejected by David Miller: > http://lists.openwall.net/netdev/2010/07/12/9 I disagree with David here, and in any case if you're going to make a style change like this they really ought to be applied over all drivers rather than just a few individual ones.