From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Date: Mon, 11 Oct 2010 13:59:34 +0100 Message-ID: <20101011125934.GM9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> <20101011123609.GL9231@rakim.wolfsonmicro.main> <20101011125056.GA25041@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id A618D10394C for ; Mon, 11 Oct 2010 14:59:35 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20101011125056.GA25041@albatros> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, Oct 11, 2010 at 04:50:56PM +0400, Vasiliy Kulikov wrote: > It is not greppable situation to simply change the behavior of all > drivers. I was looking for memory leak bugs in drivers/net/ and fixed > some of them. Manual looking through _all_ drivers takes much more > time. In general I try to search for repeatable bugs with coccinelle, > but it is rare case. The method you're using to generate the patches is pretty much orthogonal to anything else, except of course in the case where you're also submitting the automation for checking (which is useful where possible). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 11 Oct 2010 12:59:34 +0000 Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-Id: <20101011125934.GM9231@rakim.wolfsonmicro.main> List-Id: References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> <20101011123609.GL9231@rakim.wolfsonmicro.main> <20101011125056.GA25041@albatros> In-Reply-To: <20101011125056.GA25041@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasiliy Kulikov Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ian Lartey , Liam Girdwood On Mon, Oct 11, 2010 at 04:50:56PM +0400, Vasiliy Kulikov wrote: > It is not greppable situation to simply change the behavior of all > drivers. I was looking for memory leak bugs in drivers/net/ and fixed > some of them. Manual looking through _all_ drivers takes much more > time. In general I try to search for repeatable bugs with coccinelle, > but it is rare case. The method you're using to generate the patches is pretty much orthogonal to anything else, except of course in the case where you're also submitting the automation for checking (which is useful where possible). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541Ab0JKM7i (ORCPT ); Mon, 11 Oct 2010 08:59:38 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60047 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754498Ab0JKM7g (ORCPT ); Mon, 11 Oct 2010 08:59:36 -0400 Date: Mon, 11 Oct 2010 13:59:34 +0100 From: Mark Brown To: Vasiliy Kulikov Cc: kernel-janitors@vger.kernel.org, Ian Lartey , Dimitris Papastamos , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm8804: fix error handling code Message-ID: <20101011125934.GM9231@rakim.wolfsonmicro.main> References: <1286731745-18169-1-git-send-email-segooon@gmail.com> <20101011120014.GJ9231@rakim.wolfsonmicro.main> <20101011121555.GA32652@albatros> <20101011123609.GL9231@rakim.wolfsonmicro.main> <20101011125056.GA25041@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101011125056.GA25041@albatros> X-Cookie: Help a swallow land at Capistrano. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2010 at 04:50:56PM +0400, Vasiliy Kulikov wrote: > It is not greppable situation to simply change the behavior of all > drivers. I was looking for memory leak bugs in drivers/net/ and fixed > some of them. Manual looking through _all_ drivers takes much more > time. In general I try to search for repeatable bugs with coccinelle, > but it is rare case. The method you're using to generate the patches is pretty much orthogonal to anything else, except of course in the case where you're also submitting the automation for checking (which is useful where possible).