From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40593 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5J3C-0003xP-P7 for qemu-devel@nongnu.org; Mon, 11 Oct 2010 10:08:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5J1W-0004MH-JO for qemu-devel@nongnu.org; Mon, 11 Oct 2010 10:06:43 -0400 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:52548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5J1W-0004Lu-Bg for qemu-devel@nongnu.org; Mon, 11 Oct 2010 10:06:42 -0400 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9BE6coI029514 for ; Mon, 11 Oct 2010 14:06:38 GMT Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9BE6cNc3842256 for ; Mon, 11 Oct 2010 15:06:38 +0100 Received: from d06av03.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o9BE6cic009810 for ; Mon, 11 Oct 2010 15:06:38 +0100 Date: Mon, 11 Oct 2010 15:06:37 +0100 From: Stefan Hajnoczi Message-ID: <20101011140637.GC5439@stefan-thinkpad.transitives.com> References: <1286552914-27014-1-git-send-email-stefanha@linux.vnet.ibm.com> <1286552914-27014-4-git-send-email-stefanha@linux.vnet.ibm.com> <4CB18549.3020206@redhat.com> <20101011100954.GA4078@stefan-thinkpad.transitives.com> <4CB30B43.2040706@redhat.com> <20101011134241.GA5439@stefan-thinkpad.transitives.com> <4CB314C6.4040001@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CB314C6.4040001@redhat.com> Subject: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, Christoph Hellwig On Mon, Oct 11, 2010 at 03:44:38PM +0200, Avi Kivity wrote: > On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > >> > >> A leak is acceptable (it won't grow; it's just an unused, incorrect > >> freelist), but data corruption is not. > > > >The alternative is for the freelist to be a non-compat feature bit. > >That means older QEMU binaries cannot use a QED image that has enabled > >the freelist. > > For this one feature. What about others? Compat features that need to be in sync with the image state will either require specific checks (e.g. checksum or shadow of the state) or they need to be non-compat features and are not backwards compatible. I'm not opposing autoclear feature bits themselves, they are a neat idea. However, they will initially have no users so is this something we really want to carry? Stefan