From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: djwong@us.ibm.com, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org
Subject: Re: ext3/jbd: Avoid WARN() messages when failing to write the superblock
Date: Mon, 11 Oct 2010 17:17:48 +0200 [thread overview]
Message-ID: <20101011151748.GI3830@quack.suse.cz> (raw)
In-Reply-To: <4CB327BE.8000003@redhat.com>
On Mon 11-10-10 10:05:34, Eric Sandeen wrote:
> Darrick J. Wong wrote:
> > This fixes a WARN backtrace in mark_buffer_dirty() that occurs during unmount
> > when the underlying block device is removed. This bug has been seen on System
> > Z when removing all paths from a multipath-backed ext3 mount; on System P when
> > injecting enough PCI EEH errors to make the SCSI controller go offline; and
> > similar warnings have been seen (and patched) with ext2/ext4.
> >
> > The super block update from a previous operation has marked the buffer as in
> > error, and the flag has to be cleared before doing the update. (Similar code
> > already exists in ext4).
> >
> > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> > ---
>
> Probably worth mentioning the ext4 version is:
>
> commit 914258bf2cb22bf4336a1b1d90c551b4b11ca5aa
> Author: Theodore Ts'o <tytso@mit.edu>
> Date: Mon Oct 6 21:35:40 2008 -0400
>
> ext4/jbd2: Avoid WARN() messages when failing to write to the superblock
>
> This fixes some very common warnings reported by kerneloops.org
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Yup. Done. Thanks.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-10-11 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 19:35 ext3/jbd: Avoid WARN() messages when failing to write the superblock Darrick J. Wong
2010-10-05 9:30 ` Jan Kara
2010-10-11 15:05 ` Eric Sandeen
2010-10-11 15:17 ` Jan Kara [this message]
2010-10-11 16:42 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011151748.GI3830@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.