All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org, jean.pihet@newoldbits.com, "G,
	Manjunath Kondaiah" <manjugk@ti.com>
Subject: Re: [PATCH] OMAP3: PM: fix scratchpad memory accesses for off-mode
Date: Mon, 11 Oct 2010 10:03:30 -0700	[thread overview]
Message-ID: <20101011170330.GA25462@atomide.com> (raw)
In-Reply-To: <1286577825-22029-1-git-send-email-khilman@deeprootsystems.com>

* Kevin Hilman <khilman@deeprootsystems.com> [101008 15:35]:
> Commit 914bab936fe0388a529079679e2f137aa4ff548d (OMAP: mach-omap2: Fix
> incorrect assignment warnings) changed a pointer from 'u32 *' to
> 'void *' without also fixing up the pointer arithmetic.
> 
> Fix the scratchpad offsets so they are byte offsets instead of
> word offsets and thus work correctly with a void pointer base.
> 
> Special thanks to Jean Pihet for taking the time track down this
> problem and propose an initial solution.
> 
> Tested with off-idle and off-suspend on 36xx/Zoom3 and 34xx/omap3evm.
> 
> Cc: G, Manjunath Kondaiah <manjugk@ti.com>
> Reported-by: Jean Pihet <jean.pihet@newoldbits.com>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> Tony, we need this queued for 2.6.37 as this is a regression fix.

Thanks, adding to omap-for-linus.

Tony

      reply	other threads:[~2010-10-11 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 22:43 [PATCH] OMAP3: PM: fix scratchpad memory accesses for off-mode Kevin Hilman
2010-10-11 17:03 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101011170330.GA25462@atomide.com \
    --to=tony@atomide.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.