Re: [PATCH v2] misc: adds support the FSA9480 USB Switch

[Greg KH <greg@kroah.com>]

On Mon, Oct 11, 2010 at 10:32:33AM +0900, Minkyu Kang wrote:
> The FSA9480 is a USB port accessory detector and switch.
> This patch adds support the FSA9480 USB Switch.
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> v2:
>  use the threaded irq
>  fix the sysfs
> 
>  drivers/misc/Kconfig    |    9 +
>  drivers/misc/Makefile   |    1 +
>  drivers/misc/fsa9480.c  |  544 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/fsa9480.h |   40 ++++

Why do you need a .h file here for a single driver?

You are creating new sysfs files, so you are required to add a new
Documentation/ABI file as well, please add that to this patch.

And why are you exporting symbols from this driver, that should not be
needed at all.


> +/*
> + * fsa9480.c - FSA9480 micro USB switch device driver
> + *
> + * Copyright (C) 2010 Samsung Electronics
> + * Minkyu Kang <mk7.kang@samsung.com>
> + * Wonguk Jeong <wonguk.jeong@samsung.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

Are you positive about that "any later version" portion of this?

thanks,

greg k-h