All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-omap@vger.kernel.org, Charulatha V <charu@ti.com>,
	"Govindraj.R" <govindraj.raja@ti.com>
Subject: Re: [PATCH] omap: serial: Fix the boot-up crash/reboot without CONFIG_PM
Date: Mon, 11 Oct 2010 10:55:28 -0700	[thread overview]
Message-ID: <20101011175528.GC25462@atomide.com> (raw)
In-Reply-To: <8739scu6rp.fsf@deeprootsystems.com>

* Kevin Hilman <khilman@deeprootsystems.com> [101011 07:37]:
> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> >
> > This is happening because 'omap_serial_init()' is hanging in the boot.
> > On OMAP3 the watchdog is generating reboot because devices_init doesn't
> > happens where as on OMAP4 it just hangs without reboot.
> > The uart clock is not getting enabled after omap_device_idle as part
> > of omap_serial_init.
> > The omap_device_idle(will disable the clock) then omap_uart_block_sleep()
> > should enable clock back disabled during the boot up phase.
> > But omap_uart_block_sleep() stuffed version is binded only under
> > CONFIG_PM and other version is just empty. Hence it is not enabling
> > clock back as expected
> >
> > This patch adds uart clock enable code to omap_uart_block_sleep() function
> > built with CONFIG_PM disabled.
> > Thanks to Charulatha and Govindraj for their help on this debug.
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Signed-off-by: Charulatha V <charu@ti.com>
> > Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
> 
> 
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> 
> This is a regression fix, so we should queue this for 2.6.37.

Thanks, adding to omap-for-linus.

Regards,

Tony

      reply	other threads:[~2010-10-11 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 11:05 [PATCH] omap: serial: Fix the boot-up crash/reboot without CONFIG_PM Santosh Shilimkar
2010-10-11 14:46 ` Kevin Hilman
2010-10-11 17:55   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101011175528.GC25462@atomide.com \
    --to=tony@atomide.com \
    --cc=charu@ti.com \
    --cc=govindraj.raja@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.