From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] coretemp: fix reading of microcode
Date: Mon, 11 Oct 2010 23:07:50 +0000 [thread overview]
Message-ID: <20101011230750.GA6053@ericsson.com> (raw)
In-Reply-To: <4CADB0A1020000780001B335@vpn.id2.novell.com>
On Mon, Oct 11, 2010 at 11:13:00AM -0400, Fenghua Yu wrote:
> On Mon, Oct 11, 2010 at 05:40:28AM -0700, Guenter Roeck wrote:
> > On Mon, Oct 11, 2010 at 02:51:00AM -0400, Jan Beulich wrote:
> > > >>> On 09.10.10 at 20:44, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > > > Turns out the ucode revision is already available via
> > > > ucode_cpu_info[cpu].cpu_sig.rev
> > > > unless I am missing something.
> > >
> > > But you're not suggesting to make coretemp.ko depend on
> > > microcode.ko, are you?
> > >
> > I am not really suggesting anything. Personally, I think the code is just fine
> > as it is. I would just like someone to Ack it before I would want to apply
> > it, and I happened to notice the above while I was looking for other places
> > where the microcode version is retrieved.
> >
> > On the contrary, the added dependency (which I had not realized) would be
> > a good argument against using ucode_cpu_info[].
> >
> > Guenter
> >
> Acked-by: Fenghua Yu <fenghua.yu@intel.com>
>
Applied.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2010-10-11 23:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 9:36 [lm-sensors] [PATCH] coretemp: fix reading of microcode revision Jan Beulich
2010-10-07 18:46 ` Fenghua Yu
2010-10-08 7:05 ` Jan Beulich
2010-10-08 8:22 ` Jean Delvare
2010-10-08 8:59 ` Jan Beulich
2010-10-08 12:33 ` Henrique de Moraes Holschuh
2010-10-08 12:34 ` [lm-sensors] [PATCH] coretemp: fix reading of microcode Henrique de Moraes Holschuh
2010-10-08 12:44 ` [lm-sensors] [PATCH] coretemp: fix reading of microcode revision Guenter Roeck
2010-10-09 0:03 ` Henrique de Moraes Holschuh
2010-10-09 18:44 ` [lm-sensors] [PATCH] coretemp: fix reading of microcode Guenter Roeck
2010-10-11 6:51 ` Jan Beulich
2010-10-11 12:40 ` Guenter Roeck
2010-10-11 15:13 ` Fenghua Yu
2010-10-11 23:07 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011230750.GA6053@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.