From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Matthew McClintock <msm-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] When dumping from file system show results in sane order
Date: Tue, 12 Oct 2010 10:55:46 +1100 [thread overview]
Message-ID: <20101011235546.GB22383@yookeroo> (raw)
In-Reply-To: <1286305641-23388-1-git-send-email-msm-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Tue, Oct 05, 2010 at 02:07:21PM -0500, Matthew McClintock wrote:
> Currently, when we run the following
>
> $> dtc -I fs -O dts /proc/device-tree
>
> We get the output in a "reverse order", this patch will reverse that
> output order and should resemble your initial device more closely
Reverse order from what? Directory entries are unordered for most
intents and purposes - there's no guarantee that readdir() will return
entries in a consistent order, and behaviour in practice will vary
from one filesystem to another.
Your patch doesn't reverse the order - it sorts the items. If that's
what you actually want, then my general dtdiff and sorting patch will
serve you better, as Grant suggests.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2010-10-11 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 19:07 [PATCH] When dumping from file system show results in sane order Matthew McClintock
[not found] ` <1286305641-23388-1-git-send-email-msm-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-11 5:54 ` Grant Likely
[not found] ` <20101011055448.GL23588-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-11 15:12 ` Matthew McClintock
2010-10-11 23:55 ` David Gibson [this message]
2010-10-12 0:41 ` Matthew McClintock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011235546.GB22383@yookeroo \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=msm-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.