From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: [PATCH] drm/i915: new blitter ring support from Sandybridge Date: Tue, 12 Oct 2010 16:55:31 +0800 Message-ID: <20101012085531.GC7769@zhen-devel.sh.intel.com> References: <1286871232-1560-1-git-send-email-zhenyuw@linux.intel.com> <89k83a$9vg4mg@azsmga001.ch.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0579249096==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 985F09E7F3 for ; Tue, 12 Oct 2010 01:55:33 -0700 (PDT) In-Reply-To: <89k83a$9vg4mg@azsmga001.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0579249096== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2Z2K0IlrPCVsbNpk" Content-Disposition: inline --2Z2K0IlrPCVsbNpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2010.10.12 09:34:10 +0100, Chris Wilson wrote: > On Tue, 12 Oct 2010 16:13:51 +0800, Zhenyu Wang = wrote: > > This adds new ring for blitter engine starting from Sandybridge. >=20 > Thanks, look fairly straightforward. The messy parts are a clear reminder > that I intended to clean up some areas for multiple rings. >=20 > * bikeshedding >=20 > s/HAS_BLIT_SPLIT/HAS_BLT/ -- the documentation has ingrained BLT engine > into my head (and I hope they haven't changed on a whim for snb) ok, BLT looks better. >=20 > After initialisation we should not need to care about HAS_BSD/HAS_BLT and > just test whether the ring is initialised or active (depending upon op). > That should dramatically reduce the number of tests in our code and > hopefully lead to further simplifications. >=20 > Unified request list (along with per-ring lists) will sort out the mess in > i915_gem_evict and also solve the wrap-around issue. >=20 > So no get/put irq again? yeah, current still uses user_interrupt, that has been unmasked and enabled =66rom beginning. I just did some copy&paste, it could be fixed to our orig= inal behavior by mask initially and unmask as required, which might involve irq enable/disable sequence specific on different hw though. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --2Z2K0IlrPCVsbNpk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAky0IoMACgkQsQQaM014GCelDQCggVdnM8804HWCXPXFKxdYMXOE ciAAn0wfmovL9vVqeoW++gc3cGLPUz54 =mE4W -----END PGP SIGNATURE----- --2Z2K0IlrPCVsbNpk-- --===============0579249096== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0579249096==--