From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: ak4642: simultaneous playback/recorde support
Date: Tue, 12 Oct 2010 11:00:06 +0100 [thread overview]
Message-ID: <20101012100006.GD30933@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <w3p8w24rpmr.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Oct 12, 2010 at 01:39:25PM +0900, Kuninori Morimoto wrote:
> ak4642_write(codec, 0x09, 0x91);
> ak4642_write(codec, 0x0c, 0x91);
> - ak4642_write(codec, 0x00, 0x64);
> + snd_soc_update_bits(codec, 0x00, 0x64, 0x64);
Applied, but given all the magic numbers this is pretty much illegible -
it'd be good if when updating the driver you could start to convert the
magic numbers into #defines.
next prev parent reply other threads:[~2010-10-12 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 4:38 [PATCH 0/2] ASoC: simultaneous playback/recorde support for SH board Kuninori Morimoto
2010-10-12 4:39 ` [PATCH 1/2] ASoC: fsi: simultaneous playback/recorde support Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:19 ` Liam Girdwood
2010-10-12 9:33 ` Kuninori Morimoto
2010-10-12 9:41 ` Liam Girdwood
2010-10-12 10:19 ` [PATCH 1/2 v2] " Kuninori Morimoto
2010-10-15 10:06 ` Mark Brown
2010-10-12 4:39 ` [PATCH 2/2] ASoC: ak4642: " Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:38 ` Liam Girdwood
2010-10-12 10:00 ` Mark Brown [this message]
2010-10-12 10:22 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012100006.GD30933@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.