All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Pull request git://gitorious.org/bluez-mcap-hdp/mcap-hdp.git for_upstream
Date: Tue, 12 Oct 2010 11:15:41 +0100	[thread overview]
Message-ID: <20101012101541.GA25086@jh-x301> (raw)
In-Reply-To: <AANLkTikapHztx_w9mWxotJBuofYHnxMExd88V+8ng40E@mail.gmail.com>

Hi Jose,

On Tue, Oct 12, 2010, Jose Antonio Santos Cadenas wrote:
> >> On Tue, Oct 12, 2010, Jose Antonio Santos Cadenas wrote:
> >>> I'm sorry but I can't connect to the IRC rigth now. Nevertheless, I
> >>> think that I've found the issues:
> >>>
> >>> - The iochannel should be unrefereed when the watcher is explicitly removed
> >>
> >> Yes, though do you need to have a reference at all? As long as you have
> >> the GLib watch callback GLib itself holds a reference, so if you don't
> >> need one just remove chan->echo_chan and do an unref after calling
> >> add_watch.
> >
> > Sorry I've forgot this one. Gonna solve it.
> 
> Solved, I've removed the chan->echo_chan attribute and directly unref
> the io_channel once the watcher is set.

Thanks. The patches have now been pushed upstream.

Johan

  reply	other threads:[~2010-10-12 10:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 12:25 Pull request git://gitorious.org/bluez-mcap-hdp/mcap-hdp.git for_upstream Jose Antonio Santos Cadenas
2010-10-11 21:31 ` Johan Hedberg
2010-10-11 22:25   ` Jose Antonio Santos Cadenas
2010-10-11 23:23     ` Jose Antonio Santos Cadenas
2010-10-12  9:35     ` Johan Hedberg
2010-10-12  9:57       ` Jose Antonio Santos Cadenas
2010-10-12 10:02       ` Jose Antonio Santos Cadenas
2010-10-12 10:10         ` Jose Antonio Santos Cadenas
2010-10-12 10:15           ` Johan Hedberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-10-14 10:57 Jose Antonio Santos Cadenas
2010-10-14 11:15 ` Johan Hedberg
2010-10-21  7:52 Jose Antonio Santos Cadenas
2010-10-22 13:43 ` Johan Hedberg
2010-11-18 14:53 Santiago Carot-Nemesio
2010-11-18 15:03 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012101541.GA25086@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=santoscadenas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.