From: Bruno Randolf <br1@einfach.org>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] ath5k: Move debugfs under ieee80211/[wiphy-name]
Date: Tue, 12 Oct 2010 10:37:06 +0900 [thread overview]
Message-ID: <201010121037.06841.br1@einfach.org> (raw)
In-Reply-To: <1286824841-30822-1-git-send-email-greearb@candelatech.com>
On Tue October 12 2010 04:20:41 greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This automatically keeps things proper when wiphy
> is renamed.
>
> Based on patch by Johannes Berg <johannes@sipsolutions.net>
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> :100644 100644 c9732a6... 032c2ee...
> :M drivers/net/wireless/ath/ath5k/base.c 100644 100644 a342a9d...
> :673ab83... M drivers/net/wireless/ath/ath5k/debug.c
>
> drivers/net/wireless/ath/ath5k/base.c | 3 +--
> drivers/net/wireless/ath/ath5k/debug.c | 8 ++------
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c
> b/drivers/net/wireless/ath/ath5k/base.c index c9732a6..032c2ee 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -3543,8 +3543,6 @@ ath5k_pci_probe(struct pci_dev *pdev,
> sc->hw = hw;
> sc->pdev = pdev;
>
> - ath5k_debug_init_device(sc);
> -
> /*
> * Mark the device as detached to avoid processing
> * interrupts until setup is complete.
> @@ -3652,6 +3650,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
> }
> }
>
> + ath5k_debug_init_device(sc);
>
> /* ready to process interrupts */
> __clear_bit(ATH_STAT_INVALID, sc->status);
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c
> b/drivers/net/wireless/ath/ath5k/debug.c index a342a9d..673ab83 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -72,8 +72,6 @@ module_param_named(debug, ath5k_debug, uint, 0);
> #include "reg.h"
> #include "ani.h"
>
> -static struct dentry *ath5k_global_debugfs;
> -
> static int ath5k_debugfs_open(struct inode *inode, struct file *file)
> {
> file->private_data = inode->i_private;
> @@ -894,7 +892,6 @@ static const struct file_operations fops_queue = {
> void
> ath5k_debug_init(void)
> {
> - ath5k_global_debugfs = debugfs_create_dir("ath5k", NULL);
> }
>
> void
> @@ -902,8 +899,8 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
> {
> sc->debug.level = ath5k_debug;
>
> - sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
> - ath5k_global_debugfs);
> + sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
> + sc->hw->wiphy->debugfsdir);
>
> sc->debug.debugfs_debug = debugfs_create_file("debug",
> S_IWUSR | S_IRUSR,
> @@ -946,7 +943,6 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
> void
> ath5k_debug_finish(void)
> {
> - debugfs_remove(ath5k_global_debugfs);
> }
>
> void
Acked-by: Bruno Randolf <br1@einfach.org>
next prev parent reply other threads:[~2010-10-12 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 19:20 [RFC] ath5k: Move debugfs under ieee80211/[wiphy-name] greearb
2010-10-12 1:37 ` Bruno Randolf [this message]
2010-10-12 8:03 ` Johannes Berg
2010-10-12 15:35 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010121037.06841.br1@einfach.org \
--to=br1@einfach.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.