From: Ido Yariv <ido@wizery.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luciano Coelho <luciano.coelho@nokia.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/4] wl1271: Allocate TX descriptors more efficiently
Date: Tue, 12 Oct 2010 16:15:47 +0200 [thread overview]
Message-ID: <20101012141547.GC1836@WorkStation> (raw)
In-Reply-To: <1286888188.3753.4.camel@jlt3.sipsolutions.net>
On Tue, Oct 12, 2010 at 02:56:28PM +0200, Johannes Berg wrote:
> This is all under some lock, right? (If that isn't the case, it's racy)
Right.
> Therefore, you need not use atomic bitops which will be fairly
> expensive...
>
> Have you actually measured this? It seems that it con't have a huge
> effect, and the atomic bitops you use now might even negate it.
Like I mentioned in the cover letter, this is more of a cosmetic change
than a real optimization. It doesn't really improve performance, but the
code looks nicer.
Using non atomic bitops cannot hurt, I guess.
Thanks,
Ido.
next prev parent reply other threads:[~2010-10-12 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 12:49 [PATCH v3 0/4] wl1271: TX optimizations & fixes Ido Yariv
2010-10-12 12:49 ` [PATCH v3 1/4] wl1271: TX aggregation optimization Ido Yariv
2010-10-12 12:49 ` [PATCH v3 2/4] wl1271: Fix TX starvation Ido Yariv
2010-10-12 12:49 ` [PATCH v3 3/4] wl1271: Allocate TX descriptors more efficiently Ido Yariv
2010-10-12 12:56 ` Johannes Berg
2010-10-12 14:15 ` Ido Yariv [this message]
2010-10-12 14:20 ` [PATCH v4 " Ido Yariv
2010-10-12 12:49 ` [PATCH v3 4/4] wl1271: Fix TX queue low watermark handling Ido Yariv
2010-10-18 13:51 ` [PATCH v3 0/4] wl1271: TX optimizations & fixes Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012141547.GC1836@WorkStation \
--to=ido@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.