All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Problem with detection or PMBus devices
Date: Tue, 12 Oct 2010 15:47:18 +0000	[thread overview]
Message-ID: <20101012154718.GA8322@ericsson.com> (raw)
In-Reply-To: <20101011234757.GA6245@ericsson.com>

On Tue, Oct 12, 2010 at 05:06:09AM -0400, Jean Delvare wrote:
> Hi Guenter,
> 
> On Mon, 11 Oct 2010 16:47:57 -0700, Guenter Roeck wrote:
> > I have been trying to add device detection for PMBus devices to sensors-detect.
> > It works fine for LTC2978.
> > 
> > Problem is that BMR45x chips do not support QUICK commands. As a result, detection
> > code fails early on.
> > 
> > Would it make sense to extend the detection code to also try other commands
> > (eg BYTE_DATA) if QUICK does not work, or would that be too risky ?
> 
> The SMBus quick write command isn't better or worse than a few other
> SMBus commands as far as device detection is concerned. We are using it
> extensively for historical reasons: read commands used to lock up the
> SMBus on some systems when ran on clock devices. But we no longer probe
> the problematic addresses (0x69 and 0x69 mainly) anyway.
> 
> We already have a number of workarounds in place for specific cases
> (see sub i2c_probe). Depending on the address at which your BMR45x chip
> lives, a similar trick might be suitable.
> 
Valid address range is [0x03..0x0a, 0x0d..0x3f]. So it is quite a broad range.

> We may progressively move to using SMBus byte reads as the default
> probing method. After all, the actual device identification routines
> all use this command type. If this would cause any trouble, we would
> know by now. As long as i2c_safety_check() is called first, I can't
> think of any problem resulting from this change, and this would avoid
> the problem of adapters not supporting quick commands.
> 
Ok, I'll try that. Note the problem here is not the adapter - apparently
it is the bmr chips which don't support quick commands. Other chips on the
same adapter (such as the ltc2978 and max6696) are detected fine with
quick commands.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2010-10-12 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 23:47 [lm-sensors] Problem with detection or PMBus devices Guenter Roeck
2010-10-12  9:06 ` Jean Delvare
2010-10-12 15:47 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012154718.GA8322@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.