From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47644 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P5dWc-0003KA-5o
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 08:00:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1P5dWX-0007qZ-U2
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 08:00:10 -0400
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:57503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1P5dWX-0007nl-DW
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 08:00:05 -0400
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp09.au.ibm.com (8.14.4/8.13.1) with ESMTP id o9CC00rW032110
	for <qemu-devel@nongnu.org>; Tue, 12 Oct 2010 23:00:00 +1100
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o9CBxxMP3129350
	for <qemu-devel@nongnu.org>; Tue, 12 Oct 2010 22:59:59 +1100
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o9CBxxWp000380
	for <qemu-devel@nongnu.org>; Tue, 12 Oct 2010 22:59:59 +1100
From: "M. Mohan Kumar" <mohan@in.ibm.com>
Subject: Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon,
	9p}-pci
Date: Tue, 12 Oct 2010 17:29:55 +0530
References: <m3lj65122k.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3lj65122k.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201010121729.55760.mohan@in.ibm.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, Adam Litke <agl@us.ibm.com>

> Pattern:
> 
> FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls
> virtio_FOO_exit() and virtio_exit_pci().
> 
> virtio_{net,serial}_exit() call virtio_cleanup().
> 
> virtio_blk_exit() doesn't.  Why?
> 
> virtio-balloon-pci uses virtio_exit_pci() as exit method.  No
> virtio_cleanup()?
> 
> virtio-9p-pci doesn't have an exit method.  Doesn't feel right.

9p does not support hot-plug now. We will implement virtio_9p_exit when we are 
adding support for hot-plug