From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped
Date: Wed, 13 Oct 2010 09:19:55 +0100 [thread overview]
Message-ID: <20101013081954.GC6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <002701cb6aae$af084680$0d18d380$%kim@samsung.com>
On Wed, Oct 13, 2010 at 05:14:37PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:
> > Since it's exported we should make sure we're using the prototype
> > others see.
> Hmm...I'm not sure that we need really this. Of course, it can be helpful.
> But if so, we have to apply this policy/rule to all of ours...but I think we
> don't need it now.
sparse warns about this issue so fixing issues like this is required to
get a clean build for sparse users (I do pretty much all my builds with
sparse). I am sending fixes for everything I build, though obviously I
don't have access to all Samsung systems, and it does make life easier
when doing updates on the arch code.
next prev parent reply other threads:[~2010-10-13 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 17:23 [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped Mark Brown
2010-10-12 17:23 ` [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() " Mark Brown
2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim
2010-10-13 8:19 ` Mark Brown [this message]
2010-10-13 8:48 ` Kukjin Kim
2010-10-13 8:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013081954.GC6424@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.