From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: question about nested ntp
Date: Wed, 13 Oct 2010 10:57:55 +0200 [thread overview]
Message-ID: <20101013085755.GK1983@amd.com> (raw)
In-Reply-To: <20101012132611.GA28070@redhat.com>
Hi Gleb,
On Tue, Oct 12, 2010 at 09:26:11AM -0400, Gleb Natapov wrote:
> I have a question about nested ntp code. Comment in init_kvm_nested_mmu()
> function says "arch.mmu.gva_to_gpa translates l2_gva to l1_gpa". If
> I read the code correctly at the time of nested guest execution
> arch.mmu.gva_to_gpa() points to one of paging*_gva_to_gpa() variants. The
> function calls walk_addr() with provided address which should be
> l2_gva according to the comment. Now when NPF happens while nested
> guest runs arch.mmu.page_fault() is called which translates to call
> to one of paging*_page_fault() variants. paging*_page_fault() calls
> walk_addr() too, but now it gets l2_gpa as a parameter since during
> NPF svm->vmcb->control.exit_info_2 will not point to l2_gva, but l2_gpa
> instead. Do I miss something here?
No, the comment is wrong. The comment actually was right in -v1 of the
patch-series. But I changed that in -v2 and forgot the update/remove the
comment. Thanks for mentioning that :-)
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-10-13 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 13:26 question about nested ntp Gleb Natapov
2010-10-13 8:57 ` Roedel, Joerg [this message]
2010-10-13 9:59 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013085755.GK1983@amd.com \
--to=joerg.roedel@amd.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.