From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support
Date: Wed, 13 Oct 2010 09:30:58 +0200 [thread overview]
Message-ID: <201010130930.58438.sr@denx.de> (raw)
In-Reply-To: <48D3D52125C49B43AE880038E2E5314BB5BDE9@SRV101.gdsys.de>
Hi Dirk,
On Wednesday 13 October 2010 09:25:33 Eibach, Dirk wrote:
> > > +#define MDIO_ACTIVE out32(GPIO0_TCR, in32(GPIO0_TCR) |
> > > CONFIG_SYS_MDIO_PIN)
> >
> > Use out_be32() accessors here and below.
>
> Just being curious: why?
Because of the included memory barriers in the in/out_be32() functions. You
might run into problems when using the "plain" in/out32() function requiring
extra "sync" instructions.
> Has in32() also to be replaced?
Yes, of course.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-10-13 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 13:33 [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support Dirk Eibach
2010-10-12 15:11 ` Wolfgang Denk
2010-10-12 15:41 ` Stefan Roese
2010-10-13 7:25 ` Eibach, Dirk
2010-10-13 7:30 ` Stefan Roese [this message]
2010-10-13 8:23 ` Eibach, Dirk
2010-10-13 8:29 ` Wolfgang Denk
2010-10-13 9:29 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010130930.58438.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.