From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as appropriate Date: Wed, 13 Oct 2010 16:29:17 +0100 Message-ID: <20101013152916.GA20270@rakim.wolfsonmicro.main> References: <1286934472.1117.129.camel@Joe-Laptop> <20101013082414.GD6424@rakim.wolfsonmicro.main> <1286971846.1117.191.camel@Joe-Laptop> <20101013123301.GL6424@rakim.wolfsonmicro.main> <1286974549.1117.254.camel@Joe-Laptop> <20101013151117.GM6424@rakim.wolfsonmicro.main> <1286983667.1117.347.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id B3C6A24441 for ; Wed, 13 Oct 2010 17:29:18 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1286983667.1117.347.camel@Joe-Laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Joe Perches Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , Peter Hsiang , Jesse Marroquin , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Oct 13, 2010 at 08:27:47AM -0700, Joe Perches wrote: > On Wed, 2010-10-13 at 16:11 +0100, Mark Brown wrote: > > If you check the code again you will notice that these functons are all > > used in ops structures which presents obvious issues when trying to > > replace with open coded checks. > > I hope their usefulness is clear given the above. > There is some value in using consistent > function styles for table driven and non-table > driven instances. I'm sorry, I don't understand what you are saying here. What do you believe to be inconsistent? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171Ab0JMP3U (ORCPT ); Wed, 13 Oct 2010 11:29:20 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:38212 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752146Ab0JMP3T (ORCPT ); Wed, 13 Oct 2010 11:29:19 -0400 Date: Wed, 13 Oct 2010 16:29:17 +0100 From: Mark Brown To: Joe Perches Cc: Peter Hsiang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Peter Ujfalusi , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Jesse Marroquin Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as appropriate Message-ID: <20101013152916.GA20270@rakim.wolfsonmicro.main> References: <1286934472.1117.129.camel@Joe-Laptop> <20101013082414.GD6424@rakim.wolfsonmicro.main> <1286971846.1117.191.camel@Joe-Laptop> <20101013123301.GL6424@rakim.wolfsonmicro.main> <1286974549.1117.254.camel@Joe-Laptop> <20101013151117.GM6424@rakim.wolfsonmicro.main> <1286983667.1117.347.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1286983667.1117.347.camel@Joe-Laptop> X-Cookie: Dealer prices may vary. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 13, 2010 at 08:27:47AM -0700, Joe Perches wrote: > On Wed, 2010-10-13 at 16:11 +0100, Mark Brown wrote: > > If you check the code again you will notice that these functons are all > > used in ops structures which presents obvious issues when trying to > > replace with open coded checks. > > I hope their usefulness is clear given the above. > There is some value in using consistent > function styles for table driven and non-table > driven instances. I'm sorry, I don't understand what you are saying here. What do you believe to be inconsistent?