From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@suse.de>,
Boaz Harrosh <bharrosh@panasas.com>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Douglas Gilbert <dgilbert@interlog.com>,
Richard Sharpe <realrichardsharpe@gmail.com>
Subject: Re: [PATCH 2/5] tcm: Unify INQUIRY subsystem plugin handling
Date: Thu, 14 Oct 2010 02:04:21 +0200 [thread overview]
Message-ID: <20101014000421.GB15583@lst.de> (raw)
In-Reply-To: <1287001189.7334.47.camel@haakon2.linux-iscsi.org>
On Wed, Oct 13, 2010 at 01:19:49PM -0700, Nicholas A. Bellinger wrote:
> I should point out that the majority of values mentioned here (other
> than the two INQUIRY strings) are already present in struct
> se_dev_attrib and which appear as configfs attributes under
> under /sys/kernel/config/target/core/$HBA/$DEV/attrib/. This means that
> the struct se_subsystem_api calls only really used by during init
> target_core_device.c:se_dev_set_default_attribs() and
> DEV_ATTRIB(dev)->block_size, etc are used in TCM Core code.
>
> I am happy to include the two INQUIRY strings needed for emulation into
> struct se_subsystem_api directly, but I would still prefer to keep the
> function pointers for extracting values from subsystem specific code for
> the initial device attribute setup.
What's the point? It's a lot of boilerplate code that does nothing
but obsfucating what's actually going on there.
next prev parent reply other threads:[~2010-10-14 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 8:48 [PATCH 2/5] tcm: Unify INQUIRY subsystem plugin handling Nicholas A. Bellinger
2010-10-13 11:06 ` Christoph Hellwig
2010-10-13 20:19 ` Nicholas A. Bellinger
2010-10-14 0:04 ` Christoph Hellwig [this message]
2010-10-14 4:35 ` Nicholas A. Bellinger
2010-10-14 9:26 ` Christoph Hellwig
2010-10-14 9:54 ` Nicholas A. Bellinger
2010-10-14 10:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014000421.GB15583@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@suse.de \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=dgilbert@interlog.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=realrichardsharpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.