From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support
Date: Thu, 14 Oct 2010 09:57:03 +0000 [thread overview]
Message-ID: <20101014095703.GA17107@linux-sh.org> (raw)
In-Reply-To: <w3pzkuyihfm.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Oct 14, 2010 at 05:50:42PM +0900, Kuninori Morimoto wrote:
> If I use this patch on AP4,
> It said
>
> ------------[ cut here ]------------
> WARNING: at /opt/usr/src/WORK/morimoto/gitlinux/linux-2.6/lib/kref.c:34 kref_get
> +0x20/0x3c()
> Modules linked in:
> [<c002802c>] (unwind_backtrace+0x0/0xe4) from [<c0031154>] (warn_slowpath_common
> +0x4c/0x64)
> [<c0031154>] (warn_slowpath_common+0x4c/0x64) from [<c0031184>] (warn_slowpath_n
> ull+0x18/0x1c)
> [<c0031184>] (warn_slowpath_null+0x18/0x1c) from [<c014a798>] (kref_get+0x20/0x3
> c)
> [<c014a798>] (kref_get+0x20/0x3c) from [<c01d9fec>] (clk_register+0xdc/0x190)
> [<c01d9fec>] (clk_register+0xdc/0x190) from [<c000b8dc>] (sh7372_clock_init+0x20
> /0xcc)
> [<c000b8dc>] (sh7372_clock_init+0x20/0xcc) from [<c000b9f8>] (ap4evb_timer_init+
> 0x8/0x30)
> [<c000b9f8>] (ap4evb_timer_init+0x8/0x30) from [<c0009d30>] (time_init+0x14/0x1c
> )
> [<c0009d30>] (time_init+0x14/0x1c) from [<c0008834>] (start_kernel+0x154/0x244)
> [<c0008834>] (start_kernel+0x154/0x244) from [<40008034>] (0x40008034)
> ---[ end trace 1b75b31a2719ed1c ]---
>
Yes, I noticed after I sent it. You can fix this by changing it to:
if (mapping->base)
kref_get(..)
Or I can send you an updated path if you prefer.
next prev parent reply other threads:[~2010-10-14 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 5:57 [PATCH 1/2] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Kuninori Morimoto
2010-10-01 16:21 ` [PATCH 1/2] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock Guennadi Liakhovetski
2010-10-04 3:35 ` [PATCH 1/2] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock support Magnus Damm
2010-10-13 14:21 ` Paul Mundt
2010-10-14 8:50 ` [PATCH 1/2] ARM: mach-shmobile: clock-sh7372: Add FSIDIV clock Kuninori Morimoto
2010-10-14 9:57 ` Paul Mundt [this message]
2010-10-14 10:20 ` Kuninori Morimoto
2012-04-23 7:03 ` [PATCH 1/2] ARM: mach-shmobile: clock-sh73a0: add FSI clock Kuninori Morimoto
2012-05-22 2:34 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014095703.GA17107@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.