From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Date: Thu, 14 Oct 2010 08:53:49 -0400 Subject: lvconvert: provide useful error when snapshot-merge target missing In-Reply-To: <4CB6C782.6020501@redhat.com> References: <20101013185302.GA2944@redhat.com> <4CB6034D.5080603@redhat.com> <20101013214257.GC32395@agk-dp.fab.redhat.com> <4CB6C782.6020501@redhat.com> Message-ID: <20101014125349.GA8079@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Oct 14 2010 at 5:04am -0400, Zdenek Kabelac wrote: > Dne 13.10.2010 23:42, Alasdair G Kergon napsal(a): > > On Wed, Oct 13, 2010 at 09:06:53PM +0200, Milan Broz wrote: > >> I think this will break shared (external) segment module ABI. > > > > Indeed - we make no guarantees for that ABI and don't even bother > > versioning it. We don't believe there are any out-of-tree users. > > > > I'd propose to drop/turn off this feature completely - targets usually cannot > work without heavy tweaking through the rest of the code anyway. So in fact we > rather 'pretend' there is such functionality. I'm not following what you're saying. There is no pretending here... The feature fails gracefully with an informative error message. What's the problem? Mike