From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Detection of W83L771W/G in lm90
Date: Thu, 14 Oct 2010 13:20:39 +0000 [thread overview]
Message-ID: <20101014132039.GA19951@ericsson.com> (raw)
In-Reply-To: <20101014114626.7c4be041@endymion.delvare>
On Thu, Oct 14, 2010 at 05:46:26AM -0400, Jean Delvare wrote:
[ ... ]
> + if ((reg_config1 & 0x2A) = 0x00
> + && (reg_config2 & 0xF8) = 0x00) {
> + if ((chip_id & 0xFE) = 0x10 /* W83L771AWG/ASG */
> + && reg_convrate <= 0x08) {
> + name = "w83l771";
> + } else
> + if (chip_id = 0x01 /* W83L771W/G */
> + && reg_convrate <= 0x09) {
> + name = "w83l771";
> + }
If the chips have a different maximum conversion rate, that should probably be reflected
in .max_convrate as well. Unless you want to ignore it on purpose for simplicity ...
which is fine with me.
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-10-14 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 9:46 [lm-sensors] Detection of W83L771W/G in lm90 Jean Delvare
2010-10-14 9:58 ` Alexander Stein
2010-10-14 11:37 ` Jean Delvare
2010-10-14 11:51 ` Alexander Stein
2010-10-14 13:20 ` Guenter Roeck [this message]
2010-10-14 13:39 ` Jean Delvare
2010-10-14 13:48 ` Alexander Stein
2010-10-21 16:26 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014132039.GA19951@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.